Skip to content

Conversation

@hokolomopo
Copy link
Contributor

Description

The relative date criterion 'pastWeek/pastMonth/pastYear' were not correct. For example the 'pastWeek' criterion would span a period of 8 days instead of 7. The dates numbers were also not always rounded down, which could lead to some issues.

Task: 5343580

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The relative date criterion 'pastWeek/pastMonth/pastYear' were not
correct. For example the 'pastWeek' criterion would span a period of
8 days instead of 7. The dates numbers were also not always rounded down,
which could lead to some issues.

Task: 5343580
@robodoo
Copy link
Collaborator

robodoo commented Nov 20, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants