Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 21, 2025

Before this commit, the height of o-button elements was fixed to 32px, which is not enough for some content, for example when the text is on two lines (conditionnal formatting side panel for instance).

Task: 5253888

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7460

Before this commit, the height of `o-button` elements was fixed to 32px,
which is not enough for some content, for example when the text is
on two lines (conditionnal formatting side panel for instance).

Task: 5253888
X-original-commit: fd7c753
@robodoo
Copy link
Collaborator

robodoo commented Nov 21, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 21, 2025

@pro-odoo @hokolomopo cherrypicking of pull request #7460 failed.

stdout:

Auto-merging src/components/spreadsheet/spreadsheet.ts
CONFLICT (content): Merge conflict in src/components/spreadsheet/spreadsheet.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants