[IMP] mail: improve mail template usability #101399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team and
epictete
and removed request for
a team
Bertrand2
force-pushed
the
16.0-mail-template-update-bedo
branch
from
ce99ddf to
5451145
Compare
addons/mail/models/mail_template.py
Outdated
There was a problem hiding this comment.
Would be better to return a domain using fields on template model and avoid additional search queries, like (did not check it was the right one :D )
if operator == '=' and value or operation == '!=' and not value:
return [('active', operator, value), ('description', '!=', False)]
return [('active', operator, value), ('description', '=', False)]
addons/mail/models/mail_template.py
Outdated
There was a problem hiding this comment.
Just to keep fields ordered, I would define it under "name" as it is part of the template definition
Bertrand2
force-pushed
the
16.0-mail-template-update-bedo
branch
from
5451145 to
b43496a
Compare
|
Upgrade exception #141 added. Waiting the forward-port of this pr, the exception will be applied on all builds, and create an inconsistent state for migrations. If you need to apply any change before it reaches master, please notify runbot team. Details: |
|
@robodoo r+ rebase-ff |
|
@tde-banana-odoo you may want to rebuild or fix this PR as it has failed CI. |
|
Merge method set to rebase and fast-forward. |
tde-banana-odoo
force-pushed
the
16.0-mail-template-update-bedo
branch
from
b43496a to
cb0314b
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
Changes the background color of the digest to follow the company color theme the same way it has been done for the email layout. task-2944770
Allow our users to modify mail template more easily - make the list accessible from the settings - give them a link to update relevant views to update header/footer - make the list and form of templates more readable - add a description on templates, allowing to describe their usage In order to better filter templates, a new category field is added that is computed based on active flag, description being set and the template having an xml ID. Master templates are active, with a description and an xml ID. Update master data to add description on some templates. task-2944770
tde-banana-odoo
force-pushed
the
16.0-mail-template-update-bedo
branch
2 times, most recently
from
5499dd6 to
a9b9c98
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Sep 30, 2022
Changes the background color of the digest to follow the company color theme the same way it has been done for the email layout. task-2944770 Part-of: #101399
robodoo
pushed a commit
that referenced
this pull request
Sep 30, 2022
Allow our users to modify mail template more easily - make the list accessible from the settings - give them a link to update relevant views to update header/footer - make the list and form of templates more readable - add a description on templates, allowing to describe their usage In order to better filter templates, a new category field is added that is computed based on active flag, description being set and the template having an xml ID. Master templates are active, with a description and an xml ID. Update master data to add description on some templates. task-2944770 closes #101399 Related: odoo/enterprise#31916 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 30, 2022
Changes the background color of the digest to follow the company color theme the same way it has been done for the email layout. task-2944770 Part-of: #101399
robodoo
pushed a commit
that referenced
this pull request
Sep 30, 2022
Allow our users to modify mail template more easily - make the list accessible from the settings - give them a link to update relevant views to update header/footer - make the list and form of templates more readable - add a description on templates, allowing to describe their usage In order to better filter templates, a new category field is added that is computed based on active flag, description being set and the template having an xml ID. Master templates are active, with a description and an xml ID. Update master data to add description on some templates. task-2944770 closes #101399 Related: odoo/enterprise#31916 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
@Bertrand2 @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow our users to modify mail template more easily;
task-2944770