[IMP] website_event: move event question and add identification questions #112164

pko-odoo · 2023-02-08T08:54:12Z

This pr moves the code from website_event_questions to website_event and from website_event_crm_questions to website_event_crm module.

And it changes the way the identification questions (name, email, phone) are asked when registering to an event.
They aren't hardcoded anymore and can be created per event the same way other questions can be.
They can be set as mandatory or not and the order can be changed.
One can now also ask for the attendee company name.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2023-02-08T08:54:16Z

tde-banana-odoo

First validation ! Looked at global models, added some comments :) as explained on task, first step will anyway be to split the mov from the ref/imp/code cleaning, to keep history and allow to better understand changes.

Once updated and current comments answered/done, will have another look :)

Thanks and cheers !

tde-banana-odoo · 2023-03-23T09:21:33Z

addons/event/models/event_registration.py

@@ -34,6 +34,7 @@ class EventRegistration(models.Model):
    email = fields.Char(string='Email', compute='_compute_email', readonly=False, store=True, tracking=11)
    phone = fields.Char(string='Phone', compute='_compute_phone', readonly=False, store=True, tracking=12)
    mobile = fields.Char(string='Mobile', compute='_compute_mobile', readonly=False, store=True, tracking=13)
+    company = fields.Char(string='Company Name')


Seems to be a new field (don't find it in current website_event_question). In which case it should have its own commit and explanation :)

addons/event/models/event_registration.py

addons/website_event/models/event_event.py

addons/website_event/models/event_question.py

tde-banana-odoo · 2023-03-23T10:16:23Z

addons/website_event/data/event_demo.xml

@@ -171,4 +171,17 @@
        </field>
    </record>

+    <function model="event.type" name="write">


Have to say this is louche ... we generally don't update customer data even in demo mode. When using Odoo in demo mode, you will probably directly install website_event (which is the main app), which means we should have questions on demo data if we want but I don't think we need to introspect existing data and update it. Would prefer sticking on having questions on demo event types and let customer data untouched.

addons/website_event/models/event_registration.py

tde-banana-odoo · 2023-03-23T10:37:19Z

addons/website_event/models/event_type.py

+
+    @api.constrains('question_ids')
+    def _check_unique_identification_question_ids(self):
+        for event in self:


Like the other one, maybe an sql constraint on event_type_id/question_type uniqueness would be better, if possible ?

addons/website_event/views/event_question_views.xml

pko-odoo

For the constraints, I used a sql constraints in event.question model init method but the downside of this is that I can't set a custom message to it 🥲

addons/website_event/models/event_question.py

addons/website_event/views/event_question_views.xml

pko-odoo · 2023-03-28T08:35:09Z

addons/website_event/models/event_question.py

+        if 'question_type' in vals:
+            questions_new_type = self.filtered(lambda question: question.question_type != vals['question_type'])
+            if questions_new_type:
+                answer_count = self.env['event.registration.answer'].search_count([('question_id', 'in', questions_new_type.ids)])


answer_ids points towards event.question.answer not event.registration.answer. Here we are looking for the already answered questions to avoid deleting them. Or am I missing something ?

tde-banana-odoo

Second check, but some questions arise during the validation, going back to the task to ask them :) .

addons/website_event/data/event_registration_demo.xml

addons/website_event/data/event_question_demo.xml

addons/website_event/security/event_security.xml

addons/website_event/tests/__init__.py

addons/website_event/views/event_question_views.xml

addons/event/models/event_registration.py

addons/website_event/models/event_question.py

tde-banana-odoo · 2023-04-04T12:54:11Z

addons/website_event/models/event_question.py

+    @api.depends('question_type')
+    def _compute_title(self):
+        for question in self:
+            question_type_dict = dict(self._fields['question_type'].selection)


Would that be translated ?

addons/website_event/views/event_type_views.xml

tde-banana-odoo

Zboing, I think it is ok for the validation, especially if we want it for the freeze ^^ few comments, but not blocking for testing :)

tde-banana-odoo · 2023-05-05T12:53:09Z

addons/event/models/event_registration.py

@@ -34,6 +34,7 @@ class EventRegistration(models.Model):
    email = fields.Char(string='Email', compute='_compute_email', readonly=False, store=True, tracking=11)
    phone = fields.Char(string='Phone', compute='_compute_phone', readonly=False, store=True, tracking=12)
    mobile = fields.Char(string='Mobile', compute='_compute_mobile', readonly=False, store=True, tracking=13)
+    company_name = fields.Char(string='Company Name', compute='_compute_company_name', readonly=False, store=True)


Don't remember if already asked, but no tracking on this field ?

tde-banana-odoo · 2023-05-05T12:58:30Z

addons/website_event/data/event_demo.xml

@@ -36,6 +60,10 @@
                </div>
            </div>
        </field>
+        <field name="question_ids" eval="[
+            (0, 0, {'title': 'Name', 'question_type': 'name', 'is_mandatory_answer': True}),


Would do a [(5, 0), (0, 0, {...}, ..., otherwise I fear that at each -u / -i on an existing db questions pile up (or a constraint is raised because they already exists).

tde-banana-odoo · 2023-05-05T13:00:29Z

addons/website_event/models/event_question.py

+
+    def init(self):
+        # Allows only 1 same identification question per event / event type
+        self.env.cr.execute("""


Shoudln't we also have a constraint about "either event_id, either event_type_id" ?

Don't you mean like this

odoo/addons/website_event_questions/models/event_question.py

Line 27 in bf77218

@api.constrains('event_type_id', 'event_id')

? ^^

awa-odoo

Hello @pko-odoo

Not fully tested yet but here is a preliminary review so we can try to squeeze this for the freeze.

I'm already submitting those comments as they are about the MOV part.
Will make a second batch with the comments on the other commit so it's easier for you.

Thanks & cheers!

awa-odoo · 2023-05-08T07:45:36Z

addons/website_event/controllers/main.py

-            if counter == '0':
-                global_values[attr_name] = value
+            if 'question_answer' in key and value:
+                dummy, registration_index, question_id = key.split('-')


Note: you moved the code but not the associated docstring of this method, could be nice to keep it during the MOV commit.

awa-odoo · 2023-05-08T08:00:50Z

addons/website_event/security/ir.model.access.csv

@@ -7,3 +7,9 @@ access_event_tag,event.tag,event.model_event_tag,,1,0,0,0
 access_website_event_menu,website.event.menu,model_website_event_menu,,1,0,0,0
 access_website_event_menu_user,website.event.menu.user,model_website_event_menu,event.group_event_user,1,1,1,1
 access_website_visitor_user,website.visitor.user,model_website_visitor,event.group_event_user,1,1,0,0
+access_website_event_question,event.question,model_event_question,,1,0,0,0


Out of curiosity, why did you add the "website_" prefix?

Can't we keep the same names as before?

awa-odoo · 2023-05-08T08:06:18Z

addons/website_event/tests/test_website_event.py

@@ -29,6 +31,87 @@ def test_website_event_pages_seo(self):
        self.assertEqual(intro_event_menu.view_id.website_meta_title, "Hello, world!")
        self.assertEqual(event.website_meta_title, False)

+    def test_01_tickets_questions(self):


Should we rename to "test_website_event_questions" to match naming of other tests?

awa-odoo · 2023-05-08T08:11:58Z

addons/website_event/views/event_registration_views.xml

+    </record>
+
+    <record id="event_registration_view_search" model="ir.ui.view">
+        <field name="name">event.registration.view.search.inherit.website.event</field>


Looks like above naming chose "inherit.online".

awa-odoo

Hello @pko-odoo

Finished a first reading of the second commit.

Not a fan of the title magic with the "identification questions", would simplify that part.
See review comment for details and suggestions.

Rest is pretty straightforward, added some general comments about naming / test coverage / ...

Thanks for your work & cheers!

awa-odoo · 2023-05-08T08:47:35Z

addons/event/models/event_registration.py

@@ -34,6 +34,7 @@ class EventRegistration(models.Model):
    email = fields.Char(string='Email', compute='_compute_email', readonly=False, store=True, tracking=11)
    phone = fields.Char(string='Phone', compute='_compute_phone', readonly=False, store=True, tracking=12)
    mobile = fields.Char(string='Mobile', compute='_compute_mobile', readonly=False, store=True, tracking=13)
+    company_name = fields.Char(string='Company Name', compute='_compute_company_name', readonly=False, store=True)


Maybe add a small note in the commit message? Seems like we add information on the attendee as well (and not only refactor the questions stuff).

addons/website_event/controllers/main.py

awa-odoo · 2023-05-08T09:25:06Z

addons/website_event/views/event_templates_page_registration.xml

+                    <t t-if="availability_check">
+                        <t t-set="counter" t-value="0"/>
+                        <t t-set="input_type" t-value="{'name': 'text', 'email': 'email', 'phone': 'tel', 'company_name': 'text'}"/>
+                        <t t-set="type_labels" t-value="dict(env['event.question']._fields['question_type'].selection)"/>


Pretty sure those are "untranslated".

Wouldn't it be easier to keep the title field for "identification questions" in the form view and just initialize it if empty to what we want?

It would simplify and also allow end users to just change the questions label if they want to (so "Mobile" instead of "Phone" for example).

Probably to confirm with Luc.

awa-odoo · 2023-05-08T09:26:20Z

addons/website_event/models/event_question.py

+    def init(self):
+        # Allows only 1 same identification question per event / event type
+        self.env.cr.execute("""
+            CREATE UNIQUE INDEX IF NOT EXISTS event_unique_identification_question


Have to say that creates very ugly error messages on the form view :D

Can't we go for a custom api.constrains to control a bit the error messages?

awa-odoo · 2023-05-08T09:30:20Z

addons/website_event/models/event_question.py

+            if question.question_type not in ['simple_choice', 'text_box']:
+                question.title = question_type_dict.get(question.question_type)
+            elif question.title in question_type_dict.values():
+                question.title = False


Have to say I also don't understand the purpose, this seems rather complicated just for a title.

Would say let people enter what they want and initialize maybe for the "identification questions" if we want to. See other comment.

(Which makes me wonder if we even need a "is_identification_question" field).

addons/website_event/models/event_type.py

addons/website_event/views/event_templates_page_registration.xml

addons/website_event/tests/test_website_event.py

awa-odoo · 2023-05-08T09:47:21Z

addons/website_event/tests/test_event_internals.py

-            ['simple_choice', 'simple_choice', 'text_box'])
-        self.assertEqual(event.specific_question_ids.title, 'Question1')
+            ['name', 'email', 'phone', 'simple_choice', 'simple_choice', 'text_box'])
+        self.assertEqual(event.specific_question_ids.filtered(


You could also adapt to test the title of the added questions (name / phone / email) ?

The test is a few lines below ^^

awa-odoo · 2023-05-09T10:17:11Z

addons/website_event/views/event_templates_page_registration.xml

@@ -350,6 +334,10 @@
 <template id="registration_event_question" name="Registration Event Question">
    <label t-out="question.title"/>
    <span t-if="question.is_mandatory_answer">*</span>
+    <t t-if="question.is_identification_question">


Looks like "is_identification_question" is only used in tests and here in the end.

Can't we instead use input_type_by_question_type.get(question.question_type, 'some_default_value') ?

And in tests adapt a bit so that we don't need this field? Feels a bit overkill.

awa-odoo · 2023-05-10T15:14:00Z

addons/website_event/controllers/main.py

        global_values = {}
+        general_answer_ids = []


Hello @pko-odoo

Looking at current master code I think I found the answer to our earlier question.

Actually it seems that website_event had this logic:

And website_event_questions had this logic:

Which means that "global_values" was holding the field values (name / email / phone) and "general_answer_ids" was holding the question (selection and text) values.

In your current version, as you don't have specific questions for field values, you don't need "global values" anymore.

Just wanted to type this before I forget when we re-discuss tomorrow 😄
In short, it's normal, we're good.

Cheers!

awa-odoo

Hello @pko-odoo

Last bits of polishing and then we should be good to go 🚀

Thanks for keeping up with me on this & cheers!

addons/website_event/controllers/main.py

awa-odoo · 2023-05-10T15:26:17Z

addons/website_event/tests/test_event_internals.py

-            ['simple_choice', 'simple_choice', 'text_box'])
-        self.assertEqual(event.specific_question_ids.title, 'Question1')
+            ['name', 'email', 'phone', 'simple_choice', 'simple_choice', 'text_box'])
+        self.assertEqual(event.specific_question_ids.filtered(


addons/website_event/views/event_templates_page_registration.xml

awa-odoo · 2023-05-10T15:30:23Z

addons/website_event/tests/test_event_internals.py

-            'question_answer-2-%s' % self.event_question_1.id: '9',
-            'question_answer-0-%s' % self.event_question_2.id: '7',
-            'question_answer-0-%s' % self.event_question_3.id: 'Free Text',
+            '1-name-%s' % self.event_identification_question_1.id: 'Pixis',


As we have a heuristic to test that we pick the first value for multiple identification questions, could be interesting to have 2 phone questions for example, and make sure we populate the field with the first answer.

Would also be nice to include the company_name into this.

awa-odoo · 2023-05-10T15:32:03Z

( @pko-odoo Looks like runbot is still exploding by the way so make sure to re-run all tests locally and fix them 🙂 )

awa-odoo · 2023-05-11T14:32:26Z

@robodoo r+ rebase-ff

robodoo · 2023-05-11T14:33:09Z

Merge method set to rebase and fast-forward.

robodoo · 2023-05-11T15:00:12Z

@pko-odoo @awa-odoo linked pull request(s) odoo/upgrade#4313 not ready. Linked PRs are not staged until all of them are ready.

awa-odoo · 2023-05-12T05:42:16Z

@robodoo r+

awa-odoo · 2023-05-12T08:32:05Z

@robodoo r+

This commit moves the code from website_event_questions to website_event and from website_event_crm_questions to website_event_crm module. Task-3056380

This commit changes the way the identification questions (name, email, phone) are asked when registering to an event. They aren't hardcoded anymore and can be created per event the same way other questions can be. They can be set as mandatory or not and the order can be changed. One can now also ask for the attendee company name. Task-3056380

awa-odoo · 2023-05-12T14:34:51Z

@robodoo r+

This commit moves the code from website_event_questions to website_event and from website_event_crm_questions to website_event_crm module. Task-3056380 Part-of: #112164

This commit changes the way the identification questions (name, email, phone) are asked when registering to an event. They aren't hardcoded anymore and can be created per event the same way other questions can be. They can be set as mandatory or not and the order can be changed. One can now also ask for the attendee company name. Task-3056380 closes #112164 Related: odoo/upgrade#4313 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

C3POdoo requested a review from a team February 8, 2023 08:55

C3POdoo added the RD research & development, internal work label Feb 8, 2023

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 5 times, most recently from acd8654 to 8ba3c6b Compare February 14, 2023 15:37

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 2 times, most recently from e8647c1 to 7b180b2 Compare February 20, 2023 10:46

tde-banana-odoo reviewed Mar 23, 2023

View reviewed changes

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 3 times, most recently from 93f5c75 to 70e6e98 Compare March 28, 2023 08:03

pko-odoo commented Mar 28, 2023

View reviewed changes

tde-banana-odoo reviewed Apr 4, 2023

View reviewed changes

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 2 times, most recently from 0c1cd15 to 137a26b Compare April 20, 2023 15:00

tde-banana-odoo reviewed May 5, 2023

View reviewed changes

awa-odoo reviewed May 8, 2023

View reviewed changes

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch from 137a26b to b63d087 Compare May 8, 2023 09:05

awa-odoo reviewed May 8, 2023

View reviewed changes

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch from b63d087 to df6a917 Compare May 9, 2023 09:33

awa-odoo reviewed May 9, 2023

View reviewed changes

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch from df6a917 to b9cf68b Compare May 10, 2023 09:11

pko-odoo changed the title ~~[IMP] website_event: migrate website_event_questions to this module~~ [IMP] website_event: move event question and add identification questions May 10, 2023

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 3 times, most recently from 30d1922 to 9221436 Compare May 10, 2023 14:56

awa-odoo reviewed May 10, 2023

View reviewed changes

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 5 times, most recently from 08d67c6 to 8f71c43 Compare May 11, 2023 11:48

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch 2 times, most recently from e2dda20 to 77fbbc8 Compare May 11, 2023 20:59

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch from 77fbbc8 to 7230400 Compare May 12, 2023 07:44

pko-odoo added 2 commits May 12, 2023 12:45

[MOV] website_event(_crm)_questions: move event questions code

01ef0c5

This commit moves the code from website_event_questions to website_event and from website_event_crm_questions to website_event_crm module. Task-3056380

pko-odoo force-pushed the master-website-event-migrate-questions-pko branch from 7230400 to 91417e1 Compare May 12, 2023 10:46

robodoo temporarily deployed to merge May 12, 2023 20:52 Inactive

robodoo closed this May 12, 2023

robodoo added the 16.3 label May 12, 2023

fw-bot deleted the master-website-event-migrate-questions-pko branch May 26, 2023 21:46

legalsylvain mentioned this pull request Sep 9, 2023

Migration to version 17.0 OCA/OpenUpgrade#4124

Open

80 tasks

[IMP] website_event: move event question and add identification questions #112164

[IMP] website_event: move event question and add identification questions #112164

Conversation

pko-odoo commented Feb 8, 2023 • edited Loading

robodoo commented Feb 8, 2023 • edited Loading

tde-banana-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pko-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tde-banana-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tde-banana-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awa-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awa-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awa-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awa-odoo commented May 10, 2023

awa-odoo commented May 11, 2023

robodoo commented May 11, 2023

robodoo commented May 11, 2023

awa-odoo commented May 12, 2023

awa-odoo commented May 12, 2023

awa-odoo commented May 12, 2023

pko-odoo commented Feb 8, 2023 •

edited

Loading

robodoo commented Feb 8, 2023 •

edited

Loading