[IMP] base: restrict _gc_sessions to a single database #152880
Conversation
|
|
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
2 times, most recently
from
e08380f
to
588ca2e
Compare
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
from
588ca2e
to
c331760
Compare
ghost
marked this pull request as ready for review
C3POdoo
requested review from
a team,
rco-odoo,
HydrionBurst and
Julien00859
and removed request for
a team
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
from
c331760
to
7e8858d
Compare
That seems debatable, any on-premise user who has multiple databases on the same server will be tripped by this. |
|
I agree with xmo, anyone running a large system (think of our partner who are running their own SaaS plateform) kinda benefits from |
|
I think it should probably be a configuration flag of some sort, this way it's easy to toggle (including for partners if they get to a scale where it becomes useful), but it doesn't take people by surprise. |
odoo/addons/base/models/ir_http.py
Outdated
| @@ -270,6 +271,9 @@ def routing_map(self, key=None): | |||
|
|
|||
| @api.autovacuum | |||
| def _gc_sessions(self): | |||
| if not config["db_name"]: | |||
There was a problem hiding this comment.
So something like so?
| if not config["db_name"]: | |
| if os.getenv('ODOO_SKIP_GC_SESSIONS'): | |
| # on some deployment, a POSIX cron is used instead |
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
3 times, most recently
from
ddc5ff6
to
c953f5b
Compare
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
from
c953f5b
to
939d3ea
Compare
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
2 times, most recently
from
1b24cd2
to
80ab128
Compare
|
@odoo/rd-security can I have your review on this ? |
|
@joda-odoo red ci/style I see you force-pushed your branch a few times, was it due to false-positive bugs on the runbot? I'm getting quite a lot these days myself. Sometimes it is faster to "just" re-build the specific build that failed right on the runbot dashboard:
You need to be connected on runbot (via oauth with odoo.com) to be able to see the button. |
Background ========= Previously, _gc_sessions ran for all databases regardless of the active one. This could cause problems in SaaS environments with shared session storage across databases. Change ====== We propose introducing a limitation within the _gc_sessions method. The method will now check for the presence of the ODOO_SKIP_GC_SESSIONS environment variable. If set, it skips the cleanup process. This behavior is typically desired in environments launched without a specified database. On the other hand, if the environment variable is not set, the method will likely assume a non-SaaS environment (e.g., on-premise or development) and continue with the regular cleanup process. Impact ===== Ensures isolated session management for individual databases in SaaS environments. Maintains automatic cleanup for developers and on-premise users. task-3716956
ghost
force-pushed
the
master-limit_gc_sessions-joda
branch
from
80ab128
to
8bbaae0
Compare
|
@robodoo r+ |
Background ========= Previously, _gc_sessions ran for all databases regardless of the active one. This could cause problems in SaaS environments with shared session storage across databases. Change ====== We propose introducing a limitation within the _gc_sessions method. The method will now check for the presence of the ODOO_SKIP_GC_SESSIONS environment variable. If set, it skips the cleanup process. This behavior is typically desired in environments launched without a specified database. On the other hand, if the environment variable is not set, the method will likely assume a non-SaaS environment (e.g., on-premise or development) and continue with the regular cleanup process. Impact ===== Ensures isolated session management for individual databases in SaaS environments. Maintains automatic cleanup for developers and on-premise users. task-3716956 closes #152880 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Background
Previously, _gc_sessions ran for all databases regardless of the active one. This could cause problems in SaaS environments with shared session storage across databases.
Change
We propose introducing a limitation within the _gc_sessions method. The method will now check for the presence of the ODOO_SKIP_GC_SESSIONS environment variable. If set, it skips the cleanup process. This behavior is typically desired in environments launched without a specified database. On the other hand, if the environment variable is not set, the method will likely assume a non-SaaS environment (e.g., on-premise or development) and continue with the regular cleanup process.
Impact
Ensures isolated session management for individual databases in SaaS environments.
Maintains automatic cleanup for developers and on-premise users.
task-3716956