[FIX] google_calendar: sync options vanish events #167299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
geflx
force-pushed
the
16.0-google_calendar-fix_reset_sync-gdpf
branch
from
19d7286
to
624897b
Compare
geflx
force-pushed
the
16.0-google_calendar-fix_reset_sync-gdpf
branch
2 times, most recently
from
093af5d
to
e67543b
Compare
Before this commit, when performing the Google Calendar account reset in Odoo, some events and recurrences were disappearing from Odoo when they shouldn't. This was happening because we were not removing the 'google_id' information of deleted recurrences or even unlinking events incorrectly in Odoo side. Additionally, the synchronization of only 'new' or 'all existing' events were not correctly being handled because the 'need_sync' write should change according with the selected 'sync_policy'. After this commit, we correctly remove the 'google_id' of recurrences when the deleting them and we now consider correctly the 'sync_policy' of synchronizing only 'new' or 'all existing' events by updating the 'need_sync' status of all existing synchronized events. task-3731683
arj-odoo
force-pushed
the
16.0-google_calendar-fix_reset_sync-gdpf
branch
from
e67543b
to
b58bf82
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jul 26, 2024
Before this commit, when performing the Google Calendar account reset in Odoo, some events and recurrences were disappearing from Odoo when they shouldn't. This was happening because we were not removing the 'google_id' information of deleted recurrences or even unlinking events incorrectly in Odoo side. Additionally, the synchronization of only 'new' or 'all existing' events were not correctly being handled because the 'need_sync' write should change according with the selected 'sync_policy'. After this commit, we correctly remove the 'google_id' of recurrences when the deleting them and we now consider correctly the 'sync_policy' of synchronizing only 'new' or 'all existing' events by updating the 'need_sync' status of all existing synchronized events. task-3731683 closes #167299 Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when resetting the Google Calendar account in Odoo, some events and recurrences were disappearing from Odoo when they shouldn't have. This was happening because we weren't removing the 'google_id' information from deleted recurrences or even unlinking events incorrectly on the Odoo side. In addition, synchronizing only “new” or “all existing” events was not being handled correctly because the “need_sync” field should change according to the “sync_policy” selected.
Following this commit, we correctly removed the 'google_id' from the recurrences when deleting them and now correctly consider the 'sync_policy' of synchronizing only 'new' or 'all existing' events by updating the 'need_sync' status of all existing synchronized events.
task-3731683