[FIX] sale_loyalty : Don't show discounts that are already claimed

[yoba-odoo]

Steps to reproduce:

- Install eCommerce and Loyalty module
- Create a Discount that is applied using code
- Generate coupon codes
- Modify the balance of the codes to be more than 1
- Go to website and create an order
- Proceed to checkout and apply one of the codes

Current behavior before PR:

The reward will be shown as claimable even after we already applied its code. This will lead that the user can be able to claim it more than once in the same order. This is happening becuase when getting the claimable rewards we are fetching the rewards that already got applied. https://github.com/odoo/odoo/blob/16.0/addons/sale_loyalty/models/sale_order.py#L655

Desired behavior after PR is merged:

We are excluding the already-applied coupons on the order to avoid using them more than once in the same order.

opw-4018909

[robodoo]

[nle-odoo]

seems to make sense to me

[Demesmaeker]

Hello @yoba-odoo

Thanks for your fix, here is an improvement that could be made =]

Have a nice day!

[Demesmaeker]

Hello @yoba-odoo
Thanks for your changes, could you also change the title of your commit message?
The comments left are only nitpicking comments, after that, this will be ready to merge ^^
Have a nice day,

[Demesmaeker]

Thanks for your changes!

@robodoo r+

🥳

[azl-odoo]

Hi @yoba-odoo ! This change you made causes all rewards of type "discount" to disappear when any other reward is applied on the SO, even if they haven't actually been applied yet.
For exemple, we have a program with 2 reward: a free shipping reward and a discount reward, both costing a single discount point. When you trigger a rule granting 2 discount points you should be able to claim both rewards.
If you claim the discount reward first then it works fine and you can also claim the free shipping reward after.
However if you claim the free shipping reward first, then the condition you added is triggered (reward.reward_type == 'discount' and coupon in self.order_line.coupon_id) and the discount is removed from the claimable rewards.

I will let you know when the Odoo ticket is created, but I wanted to ping you so that we can hopefully get a fix as soon as possible. Don't hesitate to contact me if you want some help.
Thank you!

[yoba-odoo]

Hello @azl-odoo
Sorry for that 😅 I will try to look into it next week and ping me if any ticket got created just in case I forgot.