[FIX] project_timesheet_holidays: fix read error on employee_ids #174682
Conversation
|
|
|
@xavierbol @goffauxs Je vous tag car ça concerne du code que vous avez écrit/approuvé :) |
|
Hello @rch-asl 👋🏼 Thanks for your contribution! 🤩 May I ask you to also add a unit test? 😇 Thanks in advance! Have a nice day! 🙂 Bonjour @rch-asl 👋🏼 Merci pour ta contribution ! 🤩 Le fix me parait bon ! 🟢 Est-ce que je peux te demander d'ajouter également un test unitaire? 😇 Merci d'avance ! Passe une bonne journée ! 🙂 🌞 |
|
@rch-asl Mais bon j'imagine que tu as compris. 🙂 J'ai édité le message, on peut en effet continuer la discussion en français ou anglais. 🙂 |
rch-asl
force-pushed
the
fix-timeoff-refusal-rch
branch
2 times, most recently
from
5f5f51d
to
7a7bde3
Compare
|
@xavierbol Haha I'm sorry for using French, it's indeed better to use English so everyone can understand :) |
rch-asl
force-pushed
the
fix-timeoff-refusal-rch
branch
from
7a7bde3
to
c1b4ba9
Compare
This commit fixes a read access error on the field employee_ids of hr_leave when a user, who is not in group_hr_holidays_user, tries to cancel/refuse a timeoff. The bug only appears when the timeoff crosses a public holidays.
rch-asl
force-pushed
the
fix-timeoff-refusal-rch
branch
from
c1b4ba9
to
af32724
Compare
This commit fixes a read access error on the field employee_ids of hr_leave when a user, who is not in group_hr_holidays_user, tries to cancel/refuse a timeoff. The bug only appears when the timeoff crosses a public holidays. closes #174682 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Description of the issue/feature this PR addresses:
This commit fixes a read access error on the field employee_ids of hr_leave when a user, who is not in group_hr_holidays_user, tries to cancel/refuse a timeoff. The bug only appears when the timeoff crosses a public holiday.
Current behavior before PR:
An access error pops up when an user , who is not a timeoff officer/admin, tries to cancel a timeoff. The timeoff should cross a public holiday in order for the bug to appear.
Desired behavior after PR is merged:
The user is able to cancel its timeoff even if he/she is not a timeoff officer/admin.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr