[FIX] runbot: fix rmtree permission issues #1229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-fence
force-pushed
the
18.0-fix-rmtree-issue-moc
branch
from
f3e9bec to
d622a62
Compare
d-fence
force-pushed
the
18.0-fix-rmtree-issue-moc
branch
from
d622a62 to
1b91693
Compare
When trying to garbaged collect diretories if a file or a directory that the runbot user process own is not writable for the owner, the garbage collecting fails. The worst case is when both a file and its parent directory are not writable by the user. In that case, even by changing the file permission, the runbot cannot remove the file because of the directory not being writable. With this commit, a new `rmforest` function is made that tries, in case of permission error, to change the owner permission of the file and its parent directory to being writable before retrying to unlink them.
d-fence
force-pushed
the
18.0-fix-rmtree-issue-moc
branch
from
1b91693 to
47d67c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to garbaged collect diretories if a file or a directory that the runbot user process own is not writable for the owner, the garbage collecting fails.
The worst case is when both a file and its parent directory are not writable by the user. In that case, even by changing the file permission, the runbot cannot remove the file because of the directory not being writable.
With this commit, a new
rmforestfunction is made that tries, in case of permission error, to change the owner permission of the file and its parent directory to being writable before retrying to unlink them.