First and second chapter of the training #230

artn-odoo · 2025-01-20T15:45:44Z

No description provided.

robodoo · 2025-01-20T15:45:47Z

ethanrobv · 2025-01-21T07:56:40Z

estate/__manifest__.py

+    'demo': [
+        'demo/demo_data.xml',
+    ],
+}


You generally (actually, pretty much always) want to leave an empty newline at the end of a file

…in the models folder, where all models will be.

…scription. Can't see the database.

nesma-neha · 2025-01-20T15:56:39Z

estate/__manifest__.py

+    'demo': [
+        'demo/demo_data.xml',
+    ],
+}


You can install this extention: https://marketplace.visualstudio.com/items?itemName=riccardoNovaglia.missinglineendoffile
It does it automatically

…an underscore, which made the import useless. The security rule is now enabled and can be viewed in ir.model.access.csv in the security folder.

nesma-neha · 2025-01-21T13:36:30Z

estate/data/estate.property.csv

@@ -0,0 +1 @@
+"id","name"


You don't need this file

nesma-neha · 2025-01-21T13:40:12Z

estate/models/estate_property.py

@@ -1,6 +1,6 @@
 from odoo import models, fields

-class EstateProperty(models.Model):
+class estate_property(models.Model):


class EstateProperty(models.Model):

Python files should be in Pascal Case

nesma-neha · 2025-01-21T13:42:32Z

estate/__init__.py

+from . import models
+from . import security


Data files shouldn't be imported in the init.py
You only import folders that contain python files

nesma-neha

The commit title is the first line of the commit message.
then you should add a new line to write the commit description.

> Add a form view and a list view for the estate_property model. Also adds the action and some menu items. Refactors the model to add the needed attributes.

nesma-neha · 2025-01-21T16:35:59Z

estate/__manifest__.py

+    'data' : ['security/ir.model.access.csv',
+              'views/estate_property_view.xml',
+              'views/estate_menu.xml'],


the closing bracket should be on a separate line

nesma-neha · 2025-01-21T16:36:24Z

estate/models/estate_property.py

+
+
+


remove extra lines

nesma-neha · 2025-01-21T16:36:45Z

estate/views/estate_menu.xml

+            </menuitem>
+        </menuitem>
+    </data>
+</odoo>


add line at EOF

nesma-neha · 2025-01-21T16:37:24Z

estate/views/estate_property_view.xml

+        </record>
+    </data>
+</odoo>
+


remove extra line

A custom form and list view has been added. A custom search for almost all fields is available. A custom filter to filter out certain states has been implemented as well as a group by option on the postcode.Various view ameliorations. Various upgrades aswell in concerning the previous PR returns.

These menu items can be used to give more informations about the estate properties that has to be sold. Doesn't work as there is a bug on the Offer part of the project

The structure of the XML files was not how it should have been. Some views were called before being declared thus resulting in a bug. The chapter 7 has been completed.

The computed fields added are used to know the total area of a property and the onchange field is used to change the garden area and orientation once the checkbox is checked. The best offer for a property is also added and it changes automatically when a new best offer is created

The actions added are buttons that can change the state of models when clicked. It can change a house to the cancelled or sold status. They can accept or reject an offer and change the corresponding values in the models, like the selling price or the buyer

There are SQL constraints to make sure that tags are unique, aswell as making sure that every prices for a property is strictly positive. There is also one Python constraint to make sure that the selling price for a property is never below 90% of the expected price of that same property.

ethanrobv · 2025-01-27T08:26:37Z

estate/models/estate_property.py

@@ -62,3 +62,24 @@ def _onchange_garden(self):
        else:
            self.garden_area = 0
            self.garden_orientation = False
+
+    def cancel_property(self):


Leave a newline betwixt method definitions

resolve it

Add offers related to a type on the type form view. Add a property state as a widget on top of the form. Add an order to all models in the list view. Add a handle to change this order. Add colors for tags. Add invisible for some functionnalities if conditions are met. Add an offer as readonly on certain condition. The list view is now editable. Make date availability an optionnal in the list view. Add some decoration so it is clearer without needing to display the status. The available filter is enabled by default. Add a search domain on name and description. Add a stat button to get the number of offers related to a type. When clicked, the list view of only those offers is displayed.

ethanrobv · 2025-01-28T12:32:13Z

estate/models/estate_property_offer.py

@@ -16,6 +17,13 @@ class EstatePropertyOffer(models.Model):
    property_id = fields.Many2one("estate.property", required=True)
    validity = fields.Integer(name="Validity", default=7)
    date_deadline = fields.Date(name="Deadline", compute="_compute_deadline", inverse="_inverse_validity")
+    #property_type_id = fields.Many2one("estate.property.types", name="Property type")


ethanrobv · 2025-01-28T12:33:18Z

estate/models/estate_property_offer.py

@@ -16,6 +17,13 @@ class EstatePropertyOffer(models.Model):
    property_id = fields.Many2one("estate.property", required=True)
    validity = fields.Integer(name="Validity", default=7)
    date_deadline = fields.Date(name="Deadline", compute="_compute_deadline", inverse="_inverse_validity")
+    #property_type_id = fields.Many2one("estate.property.types", name="Property type")
+    property_type_id = fields.Many2one(
+        "estate.property.types", 


You don't have to change it all at this point, but we prefer single quotes in python files unless using double is required for some semantic reasons

ethanrobv · 2025-01-28T12:34:21Z

estate/models/estate_property_offer.py

-            if isinstance(record.create_date, fields.Date):
-                record.validity = (record.date_deadline - record.create_date).days
+            if record.date_deadline:
+                # Convert create_date to a date object if it exists


imo it doesn't need an explanation

ethanrobv · 2025-01-28T12:37:45Z

estate/views/estate_property_offer_view.xml

@@ -22,6 +23,13 @@
            <field name="view_mode">list,form</field>
            <field name="view_id" ref="view_estate_property_offer_list"/>
        </record>
+        <record id="action_estate_property_offer_from_types" model="ir.actions.act_window">
+            <field name="name">OffersFromTypes</field>


You can either make it regularly spaced, i.e., Offers from types (or whatever the name)
or you can make it snake case offers_from_types

ethanrobv · 2025-01-28T12:39:40Z

estate/views/estate_property_view.xml

@@ -94,6 +96,7 @@
                    <field name="living_area" string="Living area (m²)"/>
                    <field name="type_id" string="Property type"/>
                    <filter name="available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer received')]"/>
+                    <field name="description" string="Name and description" filter_domain="['|', ('name', 'ilike', self), ('description', 'ilike', self)]"/>


You can check equality with strings, ilike is really more for when you need wildcards/only know part of the string you are trying to match

Add a constraint on creating an offer so that the price can't be lower than the best price for that property. A warning remains in this. Add one on delete where the state can only be new or cancelled, otherwise the record won't be deleted. Extend the res.users model to add a field displaying the properties.

This is made to automatically create invoices once the house is sold. Doesn't work for now as the override of the sold_property function doesn't work.

Adds a kanban view for the estate properties, grouped by type and not draggable. The informations are not yet displayed on it.

The fields were not correctly formated and some didn't appear. They did not appear because the field state was not declared before the template so we couldn't access it's raw value.

ethanrobv · 2025-01-30T09:50:21Z

You can interactive rebase (-i) with --root to change your first commit header (which is currently causing the style check to fail)

The lingering warning has been fixed by replace the decorator on the create override method. The bug preventing the sold_property method on the new module to override the main one was caused by the model from the new module having a name. It has been fixed.

ethanrobv reviewed Jan 21, 2025

View reviewed changes

artn-odoo added 5 commits January 21, 2025 08:56

First changes

a6f7cc5

[REF] refactors the commit messages

dace4d8

[IMP] Adds the model class. The class only has a name for now, it is …

de9ee05

…in the models folder, where all models will be.

[IMP] change the commits name to fit company regulations

471b0f4

[IMP] Adds the model class. The class only has a name for now, it is …

0edf76f

…in the models folder, where all models will be.

artn-odoo force-pushed the 18.0-training-artn branch from 4fa9c6b to 0edf76f Compare January 21, 2025 08:48

[IMP] adds the base for the estate module such as the name and the de…

3506143

…scription. Can't see the database.