Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] supplier_portal, event_ticket_limit: add module for supplier portal, event ticket restriction #236

Closed
wants to merge 3 commits into from

Conversation

nipl-odoo
Copy link

@nipl-odoo nipl-odoo commented Jan 22, 2025

  • Implement a supplier portal that allows vendors to upload their bills. Vendors will be able to view the companies they are associated with and upload bills in both PDF and XML formats.

  • Once the documents are successfully uploaded, a new draft vendor bill will be created in the backend.
    Task - 4496581

  • Added a module to limit the number of tickets a user can book per registration.

  • A new field has been introduced in the list view; if this field is set to 0, it indicates that there is no limit on the number of tickets per registration.

  • All previous restrictions will remain in effect.
    Task - 4500439

  • Add a module that adds warranty as a product in sale order line. Users can configure generic warranty configurations from sales-> menu -> product -> Warranty Config.

  • Whenever there is a warranty product in our sales order lines we can click on add warranty button in view and a wizard will open from which we can add type of warranty we configured in warranty config view.

  • We can mark product as warranty product in product template form view's sales section. Also warranty can be seen as sales order line in print report too.
    Task - 4504888

@robodoo
Copy link

robodoo commented Jan 22, 2025

Pull request status dashboard

Copy link

@aktr-odoo aktr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I have left a few comments. Can you please have a look.

event_ticket_limit/__manifest__.py Outdated Show resolved Hide resolved
event_ticket_limit/__manifest__.py Outdated Show resolved Hide resolved
event_ticket_limit/__manifest__.py Outdated Show resolved Hide resolved
event_ticket_limit/__manifest__.py Show resolved Hide resolved
event_ticket_limit/models/event_ticket.py Outdated Show resolved Hide resolved
Copy link

@aktr-odoo aktr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
I have left a few comments. Can you please have a look?

supplier_portal/__manifest__.py Outdated Show resolved Hide resolved
supplier_portal/__manifest__.py Outdated Show resolved Hide resolved
supplier_portal/__manifest__.py Outdated Show resolved Hide resolved
supplier_portal/__manifest__.py Outdated Show resolved Hide resolved
supplier_portal/controllers/portal_controller.py Outdated Show resolved Hide resolved
supplier_portal/controllers/portal_controller.py Outdated Show resolved Hide resolved
supplier_portal/controllers/portal_controller.py Outdated Show resolved Hide resolved
Add supplier portal for vendors to upload their bills. Vendors can see the
companies they're related to and can upload bills in pdf and xml format.

After successfully uploading documents new draft vendor bill is created in
backend.

Task-4496581
@nipl-odoo nipl-odoo force-pushed the 18.0-practice-task-nipl branch 2 times, most recently from 4b06f6c to 940e332 Compare January 24, 2025 08:03
Add module for limiting number of tickets a user can book per registration.
A new field is shown in list view, if kept 0 that means there's no limit for
tickets per registration.

Remove redundant code with correct manifest format
All the earlier restrictions persists.

Task-4500439
@nipl-odoo nipl-odoo force-pushed the 18.0-practice-task-nipl branch from 940e332 to a01cc67 Compare January 24, 2025 10:14
Copy link

@aktr-odoo aktr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I have left a few comments. Can you please have a look?

product_warranty/__manifest__.py Outdated Show resolved Hide resolved
product_warranty/models/__init__.py Outdated Show resolved Hide resolved
product_warranty/models/sale_order.py Outdated Show resolved Hide resolved
product_warranty/models/sale_order_line.py Outdated Show resolved Hide resolved
product_warranty/security/ir.model.access.csv Outdated Show resolved Hide resolved
product_warranty/wizard/__init__.py Outdated Show resolved Hide resolved
product_warranty/wizard/product_warranty_wizard.py Outdated Show resolved Hide resolved
@nipl-odoo nipl-odoo force-pushed the 18.0-practice-task-nipl branch from a01cc67 to f9ffd66 Compare January 24, 2025 12:31
Copy link

@aktr-odoo aktr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Comment on lines 22 to 32
warranty = self.env["product.warranty.wizard.line"].create(
{
"sale_order_line_id": line.id,
"warranty_config_id": False,
}
)
warranty_lines.append(Command.link(warranty.id))

res["sale_order_id"] = sale_order.id
res["line_ids"] = warranty_lines

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to create and then link.
You can directly use create in line_ids.

HINT: Refer codebase

Add product warranty module which adds warranty product by clicking on 'Add
Warranty' button in quotation on addition of related product in sales order line
Also by deleting the product warranty will also get removed. Add warranty as
sale order line so we can see it as any other product in sales order in print
report.

Firstly we need to configure warranty from warranty config.(Which is located
in sales-> menu -> Configuration -> (Under product section) -> Warranty Config)

By clicking on is warranty product on product template's sales section we can
mark that product as warranty product.

task - 4504888
@nipl-odoo nipl-odoo force-pushed the 18.0-practice-task-nipl branch from f9ffd66 to 23d7ae3 Compare January 27, 2025 05:48
@nipl-odoo nipl-odoo closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants