Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] estate: created estate module in odoov18 #241

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

Hassan-Osama
Copy link

  • created house model
  • created offer, tags with their relationships to the house model
  • added the menus/actions and views for the created models

- created house model
- created offer, tags with their relationships to the house model
- added the menus/actions and views for the created models
@robodoo
Copy link

robodoo commented Jan 27, 2025

Pull request status dashboard

Comment on lines +6 to +11
'data': ['views/estate_property_views.xml',
'views/estate_menus.xml',
'security/ir.model.access.csv',
'views/estate_property_type_views.xml',
'views/estate_property_tag_views.xml',
'views/estate_property_offer_views.xml'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'data': ['views/estate_property_views.xml',
'views/estate_menus.xml',
'security/ir.model.access.csv',
'views/estate_property_type_views.xml',
'views/estate_property_tag_views.xml',
'views/estate_property_offer_views.xml'],
'data': [
'views/estate_property_views.xml',
'views/estate_menus.xml',
'security/ir.model.access.csv',
'views/estate_property_type_views.xml',
'views/estate_property_tag_views.xml',
'views/estate_property_offer_views.xml',
],

from . import estate_property
from . import estate_property_type
from . import estate_property_tag
from . import estate_property_offer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty line @ EOF

Comment on lines +1 to +6
from odoo import fields, models
from dateutil.relativedelta import relativedelta
from odoo import api, _
from odoo.exceptions import UserError
from odoo.exceptions import ValidationError
from odoo.tools.float_utils import float_compare, float_is_zero

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group and remove duplicate imports for clarity.

Suggested change
from odoo import fields, models
from dateutil.relativedelta import relativedelta
from odoo import api, _
from odoo.exceptions import UserError
from odoo.exceptions import ValidationError
from odoo.tools.float_utils import float_compare, float_is_zero
from odoo import fields, models, api, _
from dateutil.relativedelta import relativedelta
from odoo.exceptions import UserError, ValidationError
from odoo.tools.float_utils import float_compare, float_is_zero

if record.create_date:
record.date_deadline = record.create_date + timedelta(days=record.validity)
else:
record.date_deadline = fields.Date.today() + timedelta(days=record.validity)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add empty lines between methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants