SAWER Onboarding #997
Open
SAWER Onboarding #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sawer-odoo
force-pushed
the
19.0-onboarding-sawer
branch
from
6c30ded to
c0452ec
Compare
Mathilde411
requested changes
Oct 21, 2025
estate/security/ir.model.access.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
estate/views/estate_menus.xml
Outdated
|
|
||
| </menuitem> | ||
|
|
||
| </odoo> No newline at end of file |
| </field> | ||
| </record> | ||
|
|
||
| </odoo> No newline at end of file |
Comment on lines
9
to
54
| name = fields.Char( | ||
| string='Name', | ||
| required=True | ||
| ) | ||
| description = fields.Text(string='Description') | ||
| postcode = fields.Char(string='Post code') | ||
| date_availability = fields.Date( | ||
| string='Availability date', | ||
| default=fields.Date.add(fields.Date.today(), months=3), | ||
| copy=False | ||
| ) | ||
| expected_price = fields.Float(string='Expected price', required=True) | ||
| selling_price = fields.Float( | ||
| string='Selling price', | ||
| readonly=True, | ||
| copy=False | ||
| ) | ||
| bedrooms = fields.Integer( | ||
| string='Bedrooms', | ||
| default=2 | ||
| ) | ||
| living_area = fields.Integer(string='Living area') | ||
| facades = fields.Integer(string='Facades') | ||
| garage = fields.Boolean(string='Garage') | ||
| garden = fields.Boolean(string='Garden') | ||
| garden_area = fields.Integer(string='Garden area') | ||
| garden_orientation = fields.Selection( | ||
| string='Garden orientation', | ||
| selection= [('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')] | ||
| ) | ||
| active = fields.Boolean( | ||
| string='Active', | ||
| default=True | ||
| ) | ||
| state = fields.Selection( | ||
| string='State', | ||
| selection= [('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')], | ||
| default='new' | ||
| ) |
There was a problem hiding this comment.
Suggested change
| name = fields.Char( | |
| string='Name', | |
| required=True | |
| ) | |
| description = fields.Text(string='Description') | |
| postcode = fields.Char(string='Post code') | |
| date_availability = fields.Date( | |
| string='Availability date', | |
| default=fields.Date.add(fields.Date.today(), months=3), | |
| copy=False | |
| ) | |
| expected_price = fields.Float(string='Expected price', required=True) | |
| selling_price = fields.Float( | |
| string='Selling price', | |
| readonly=True, | |
| copy=False | |
| ) | |
| bedrooms = fields.Integer( | |
| string='Bedrooms', | |
| default=2 | |
| ) | |
| living_area = fields.Integer(string='Living area') | |
| facades = fields.Integer(string='Facades') | |
| garage = fields.Boolean(string='Garage') | |
| garden = fields.Boolean(string='Garden') | |
| garden_area = fields.Integer(string='Garden area') | |
| garden_orientation = fields.Selection( | |
| string='Garden orientation', | |
| selection= [('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')] | |
| ) | |
| active = fields.Boolean( | |
| string='Active', | |
| default=True | |
| ) | |
| state = fields.Selection( | |
| string='State', | |
| selection= [('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')], | |
| default='new' | |
| ) | |
| name = fields.Char(required=True) | |
| description = fields.Text() | |
| postcode = fields.Char() | |
| date_availability = fields.Date( | |
| string='Availability date', | |
| default=fields.Date.add(fields.Date.today(), months=3), | |
| copy=False | |
| ) | |
| expected_price = fields.Float(required=True) | |
| selling_price = fields.Float( | |
| readonly=True, | |
| copy=False | |
| ) | |
| bedrooms = fields.Integer(default=2) | |
| living_area = fields.Integer() | |
| facades = fields.Integer() | |
| garage = fields.Boolean() | |
| garden = fields.Boolean() | |
| garden_area = fields.Integer() | |
| garden_orientation = fields.Selection( | |
| selection= [('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')] | |
| ) | |
| active = fields.Boolean(default=True) | |
| state = fields.Selection( | |
| selection= [('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')], | |
| default='new' | |
| ) |
Here the string are correctly generated from the variable names,no need for them :)
estate/models/estate_property.py
Outdated
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate.property" | ||
| _description = "Create a new table" |
There was a problem hiding this comment.
Description should be a human readable name for you model.
e.g. for model with _name = 'sale.order' we have _description = "Sales Order"
[ADD] Chapter 2 sawer - correction
[FIX] missing space correction
[FIX] estate.propety.offer_id existence verification [FIX] trailing white space in estate_property_offer: 34
[FIX] missing files in button definition [FIX] using unknown field "states" from copy paste
[FIX] blank spaces [FIX] whitespace arround operator [IMP] estate: Add notes.
[FIX] definition order in manifest.
sawer-odoo
force-pushed
the
19.0-onboarding-sawer
branch
3 times, most recently
from
53bdc5a to
50d4671
Compare
[FIX] erased the print [ADD] Unittest offer creation (chapter 12)
[FIX] style fix for runbot
sawer-odoo
force-pushed
the
19.0-onboarding-sawer
branch
3 times, most recently
from
6d936e8 to
5639d34
Compare
[IMP] modify garden onchange condition
[FIX] runbot style issues
sawer-odoo
force-pushed
the
19.0-onboarding-sawer
branch
from
5639d34 to
19e64f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sawer chapter 2