[FIX] models: fix filters model_id correclty #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This kind of where clause is preparing due to that while merging model filters are not updating ``` NOT EXISTS(SELECT 1 FROM ir_filters o WHERE o.user_id = t.user_id AND o.action_id = t.action_id AND o.name = t.name AND o.model_id=%(new)s) AND NOT EXISTS(SELECT 1 FROM ir_filters o WHERE true AND o.model_id=%(new)s) ``` because while checking not exist ``SELECT 1 FROM ir_filters o WHERE true AND o.model_id=%(new)s`` there are filters exist of new model(in that model is merging) due to this condition didn't fulfill and ``model_id`` is set as ``_unknown`` during remove call. this condition should be there if Indirect reference ``res_model`` it self have the unique constraint. So, that is only on ir_model handled accordingly. original record ``` select id,model_id from ir_filters where id in (100,210,101,87,194,103,214,105,202,177,178,207) ; id | model_id -----+------------------- 87 | sale.subscription 100 | sale.subscription 101 | sale.subscription 103 | sale.subscription 105 | sale.subscription 210 | sale.subscription 177 | sale.subscription 178 | sale.subscription 194 | sale.subscription 202 | sale.subscription 207 | sale.subscription 214 | sale.subscription ``` before fix ``` sagu_2403383_upg=> select id,model_id from ir_filters where id in (100,210,101,87,194,103,214,105,202,177,178,207) ; id | model_id -----+---------- 87 | _unknown 100 | _unknown 101 | _unknown 178 | _unknown 103 | _unknown 105 | _unknown 202 | _unknown 177 | _unknown 194 | _unknown 207 | _unknown 210 | _unknown 214 | _unknown (12 rows) ``` after fix ``` sagu_2403383_17.0=> select id,model_id from ir_filters where id in (100,210,101,87,194,103,214,105,202,177,178,207) ; id | model_id -----+------------ 87 | sale.order 100 | sale.order 101 | sale.order 103 | sale.order 105 | sale.order 177 | sale.order 178 | sale.order 194 | sale.order 202 | sale.order 207 | sale.order 210 | sale.order 214 | sale.order ``` opw-4381532
sagu-odoo
force-pushed
the
master-fix_model_id_assign-sagu
branch
from
4bb5081 to
7e6a999
Compare
|
Hello @odoo/upgrade , could you please review the pr ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of where clause is preparing due to that while merging models filters
model_idis not updatingbecause while checking not exist
SELECT 1 FROM ir_filters o WHERE true AND o.model_id=%(new)sthere are filters exist of new model(in that model is merging) due to this condition didn't fulfill andmodel_idis set as_unknownduring remove call( because here it didn't updated before remove_model method call). This above mentioned condition should be there if Indirect referenceres_modelit self have the unique constraint. So, that is only on ir_model handled accordingly likeir_modelhavemodelfield which have unique constraint.original record
before fix
after fix
opw-4381532