[IMP] util/report: do not show None or empty link #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we get unexpected empty (or NULL) values in some records when reporting about them. To avoid `None` or just an empty link we make a default value for `name` in such cases.
Contributor
|
|
Contributor
|
upgradeci retry with always only hr |
KangOl
approved these changes
Feb 25, 2025
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 3, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name, it fails with Updated get_anchor_link_to_record to default 'name' to None if not provided. Also added a check to ensure 'id' is not a tuple before proceeding with its use.
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 3, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name, it fails with Updated get_anchor_link_to_record to default 'name' to None if not provided. Also added a check to ensure 'id' is not a tuple before proceeding with its use.
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 3, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name, it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided. Also added a check to ensure 'id' is not a tuple before proceeding with its use.
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 3, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name, it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided. Also added a check to ensure 'id' is not a tuple before proceeding with its [use](https://github.com/odoo/upgrade-util/blob/master/src/util/report.py#L328-L330).
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 4, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name,it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided. Also added a check to ensure 'id' is not a tuple before proceeding with its [use](https://github.com/odoo/upgrade-util/blob/master/src/util/report.py#L328-L330).
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 8, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name,it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided. Also added a check to ensure 'id' is not a tuple before proceeding with its [use](https://github.com/odoo/upgrade-util/blob/master/src/util/report.py#L328-L330).
depr-odoo
added a commit
to odoo-dev/upgrade-util
that referenced
this pull request
Sep 8, 2025
This [commit](odoo#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name,it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided.
robodoo
pushed a commit
that referenced
this pull request
Sep 8, 2025
This [commit](#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name,it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided. closes #312 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 8, 2025
This [commit](#215) ensure that if the name argument is not provided, it will automatically generate a default value for name based on the model and id. When we call method get_anchor_link_to_record without name,it fails with ``` TypeError: get_anchor_link_to_record() missing 1 required positional argument: 'name' ``` Updated get_anchor_link_to_record to default 'name' to None if not provided. closes #312 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we get unexpected empty (or NULL) values in some records when reporting about them. To avoid
Noneor just an empty link we make a default value fornamein such cases.