[IMP] util/orm: recompute_fields add query parameter
#317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
|
upgradeci skip |
aj-fuentes
force-pushed
the
master-recompute_query-afu
branch
from
7fca3a9 to
94ca49a
Compare
Contributor
Author
|
upgradeci retry with always only base account crm delivery helpdesk_sale_timesheet helpdesk_timesheet hr_attendance hr_expense hr_holidays hr_recruitment_extract l10n_in_sale l10n_it_edi l10n_mx_edi_stock loyalty mrp point_of_sale pos_sale project_enterprise purchase resource sale sale_project_forecast sale_renting sale_stock sale_subscription sale_timesheet_margin stock |
KangOl
reviewed
Sep 10, 2025
KangOl
reviewed
Sep 10, 2025
aj-fuentes
force-pushed
the
master-recompute_query-afu
branch
from
94ca49a to
8e304a7
Compare
In most cases when we pass a list of `ids` to `recompute_fields` we just run a query to get them. The main downside of this approach is when the list is too big: it can cause MemoryErrors. Instead we can let `recompute_fields` use a query to get the ids and take the necessary precautions to not fetch millions of entries all at once. As a nice side effect code becomes easier to review since we don't need to check the fetching of ids is done correctly.
aj-fuentes
force-pushed
the
master-recompute_query-afu
branch
from
8e304a7 to
a01bb83
Compare
Contributor
|
upgradeci retry |
jjmaksoud
reviewed
Sep 11, 2025
KangOl
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases when we pass a list of
idstorecompute_fieldswe just run a query to get them. The main downside of this approach is when the list is too big: it can cause MemoryErrors. Instead we can letrecompute_fieldsuse a query to get the ids and take the necessary precautions to not fetch millions of entries all at once. As a nice side effect code becomes easier to review since we don't need to check the fetching of ids is done correctly.