[IMP] util/pg: allow multiple parallel filters #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KangOl
reviewed
Jan 16, 2024
src/util/pg.py
Outdated
| return [query.format(parallel_filter=parallel_filter)] | ||
|
|
||
| parallel_filter = "{alias}.id BETWEEN %s AND %s".format(alias=alias) | ||
| parallel_filter = "{alias}.id BETWEEN %(low)s AND %(high)s".format(alias=alias) |
Contributor
There was a problem hiding this comment.
Nitpicking on variable name:
Suggested change
| parallel_filter = "{alias}.id BETWEEN %(low)s AND %(high)s".format(alias=alias) | |
| parallel_filter = "{alias}.id BETWEEN %(lower-bound)s AND %(upper-bound)s".format(alias=alias) |
When exploding a query we may need to add the same parallel filter in multiple places.
aj-fuentes
force-pushed
the
master-imp_explode-afu
branch
from
508cd09 to
4402958
Compare
Contributor
|
upgradeci retry with always only hr |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 16, 2024
When exploding a query we may need to add the same parallel filter in multiple places. closes #38 Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exploding a query we may need to add the same parallel filter in multiple places.