Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] The read_group returns the cost summatory, but should the is co… #1283

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

rossasa
Copy link

@rossasa rossasa commented Aug 15, 2016

…st average, so this commit compute each line to get the right average value for the product

this tries to solve the same problem that #1276

…st average, so this commit compute each line to get the right average value for the product
@ltobar
Copy link

ltobar commented Aug 17, 2016

Rossasa, your commit only work when do not exist "Reverse Transfer" movements, the search take all quants and the result is an average price inaccurate.

@agaldona
Copy link
Collaborator

In my opinion problem is not filtering quants by location, and that the cost was multiplied by the quantity of quants found. I do not think it is required to compute average cost quant by quant as the cost will be the same for each one, take into account that this code will be executed only when product cost method is average cost.

@agaldona
Copy link
Collaborator

agaldona commented Sep 6, 2016

@anajuaristi @pedrobaeza @rossasa @ltobar What do you think about it?

@ltobar
Copy link

ltobar commented Sep 6, 2016

Hi, we are used filtered domain and work fine for average cost.

On Tue, Sep 6, 2016, 11:46 agaldona notifications@github.com wrote:

@anajuaristi https://github.com/anajuaristi @pedrobaeza
https://github.com/pedrobaeza @rossasa https://github.com/rossasa
@ltobar https://github.com/ltobar What do you think about it?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1283 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHR0ci4l6j6rYnyoIfN39yjx2ARAOYFxks5qnXzHgaJpZM4Jk4h4
.

@@ -245,10 +245,12 @@ def _product_price_update(self, move, new_price):
('product_id', 'in',
product.product_tmpl_id.product_variant_ids.ids),
('id', 'not in', move.quant_ids.ids)]
Copy link
Collaborator

@agaldona agaldona Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossasa Can you add a control by location usage? The quants to take into account must be internal only. In the other case you are summing the amounts of the old quants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants