Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor problem with graphing #145

Closed
aferragu opened this issue Jun 16, 2018 · 2 comments
Closed

Minor problem with graphing #145

aferragu opened this issue Jun 16, 2018 · 2 comments

Comments

@aferragu
Copy link
Contributor

I'm using your (great so far!) library and following your tutorials. I would like to report a minor issue: when graphing the value functions, the generated file using plotly is a temp file with no html extension (at least on Linux). Hence the browser window pops up but it does not parse the html output.

I tracked the issue to launch_file in visualize.jl where you do:
launch_file(html_string, assets, outputfile=replace(tempname(), ".tmp", ".html"))

However tempname() does not return an extension .tmp, so nothing gets replaced. It should be:
launch_file(html_string, assets, outputfile=tempname() * ".html")

Thanks!
Andrés

@odow
Copy link
Owner

odow commented Jun 16, 2018

Im away from my computer at the moment, but a quick google suggests:
JuliaLang/julia#9053 (comment)

Pull requests accepted :) I only have a windows machine to test, and Travis doesn't let me open a browser window, but the function could be refactored to test that the html file is created.

If you have a look, you can also pass your own filename instead of a temporary one.

@odow
Copy link
Owner

odow commented Jun 16, 2018

I'm using your (great so far!) library and following your tutorials

Thanks! The tutorials are very much a recent work in progress. They are probably riddled with spelling mistakes etc. If anything isn't clear, let me know because I tend to forget which parts are obvious to me :)

@odow odow closed this as completed in #146 Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants