Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plotting on *NIX machines #146

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Fix plotting on *NIX machines #146

merged 1 commit into from
Jun 17, 2018

Conversation

odow
Copy link
Owner

@odow odow commented Jun 16, 2018

Closes #145

the latter has different behaviour on *NIX and Windows machines.
@odow
Copy link
Owner Author

odow commented Jun 16, 2018

Hi @aferragu do you mind testing that this works?

You can either checkout this PR using Julia:

Pkg.checkout("SDDP", "fix-visualize")

Then, once this branch is merged you can get back to master by:

Pkg.free("SDDP")
# or 
Pkg.checkout("SDDP", "master")

Alternatively, if you know much about Git you can just do it via the command line.

@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #146 into master will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   90.58%   90.71%   +0.13%     
==========================================
  Files          29       29              
  Lines        1392     1390       -2     
==========================================
  Hits         1261     1261              
+ Misses        131      129       -2
Impacted Files Coverage Δ
src/visualizer/visualize.jl 28.57% <ø> (ø) ⬆️
src/visualizer/visualize_simulation.jl 87.5% <0%> (+9.72%) ⬆️
src/visualizer/visualize_value_function.jl 93.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab81770...990ac40. Read the comment docs.

@aferragu
Copy link
Contributor

That should do it. I can confirm it works on *NIX. Thanks!

@odow odow merged commit 5c1d317 into master Jun 17, 2018
@odow
Copy link
Owner Author

odow commented Jun 17, 2018

Thanks @aferragu! If you know anything about JavaScript, #36 needs work :)

@odow odow deleted the fix-visualize branch June 17, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants