Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Publish connector maven artifacts to maven central (Release & Merge) #16

Closed
planetf1 opened this issue Feb 24, 2021 · 9 comments
Closed
Assignees

Comments

@planetf1
Copy link
Member

In odpi/egeria#4664 the main egeria code switched to publishing maven artifacts for a release via github actions direct to maven central. Additionally snapshots are also published to maven central

Github actions need to be put in place for this repo once the connector is updated & in a representative state
cc: @wbittles

@planetf1
Copy link
Member Author

planetf1 commented Mar 5, 2021

This can likely follow the same approach as adopted for base egeria (above) which has now been proven for the 2.7 release.
However here we are using gradle vs maven so will need to implement using the appropriate gradle plugins - an ideal way to identify the details prior to switching egeria fully to gradle in future.

The end result would be connectors available on maven central - snapshot or released.

The only additional questions are :

  • Do we need the connector pushed to another repo (like github maven repo) - I'd be inclined to not do so
  • Do we want to store any specific build output alongside the build (for download or more likely debugging)

@planetf1 planetf1 self-assigned this Mar 8, 2021
@planetf1
Copy link
Member Author

planetf1 commented Mar 8, 2021

My proposal is to:

  • get the connector up to date - see Update build to get latest snapshots #14 and https://github.com/odpi/egeria-database-connectors/pulls
  • modify the gradle build to create a single artifact org.odpi.egeria:postgres-connector (though I expect the name will be the toughest one to get agreement too - perhaps worth bringing up on the status call tomorrow). I'd personally err on a simple, obvious name, any ideas?
  • Modify the build pipeline along the lines of what egeria does but i) gradle [not maven] ii) no docker - ie publishing snapshots and releases to maven central

With this done we could think about #5 where the intent was to actually deploy an environment using the connector - live/real server then test against

@planetf1
Copy link
Member Author

planetf1 commented Mar 8, 2021

^ @wbittles

@planetf1
Copy link
Member Author

planetf1 commented Mar 8, 2021

As per discussion - feel free to assign back if you need a hand or would like me to do this

@planetf1 planetf1 assigned wbittles and unassigned planetf1 Mar 8, 2021
@github-actions
Copy link

github-actions bot commented May 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@planetf1
Copy link
Member Author

The sas viya connector is now publishing artifacts to maven central. See

We probably don't need a custom docker image, but if so that repo also has a custom Dockerfile

Credentials need adding to this repo for publishing to work

@wbittles let me know if/when you'd like me to do this, or you would like to do it (except the credentials which I need to manage until the LF take them over)

@planetf1
Copy link
Member Author

Added required Secrets for publishing pipeline.
Will update build jobs once #46 merged

planetf1 added a commit that referenced this issue May 26, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 26, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 26, 2021
#16 update build pipelines to publish to sonatype/maven central
planetf1 added a commit that referenced this issue May 26, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 26, 2021
planetf1 added a commit that referenced this issue May 26, 2021
…tion

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 26, 2021
#16 rename connector dir & maven artifact to conform to egeria conven…
@planetf1
Copy link
Member Author

Builds are consistently failing with:

/home/runner/work/egeria-database-connectors/egeria-database-connectors/egeria-connector-postgres/src/main/java/org/odpi/openmetadata/adapters/connectors/integration/postgres/mapper/PostgresMapper.java:55: error: cannot find symbol
> Task :egeria-connector-postgres:compileJava
        schemaProps.setOwner(sch.getSchema_owner());
                   ^
  symbol:   method setOwner(java.lang.String)
  location: variable schemaProps of type org.odpi.openmetadata.accessservices.datamanager.properties.DatabaseSchemaProperties
1 error


> Task :egeria-connector-postgres:compileJava FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/7.0.2/userguide/command_line_interface.html#sec:command_line_warnings
1 actionable task: 1 executed
FAILURE: Build failed with an exception.
  • Happened consistently with multiple PRs
  • not addressed by flipping java version (in case of env. differences)
  • consistent build locally
  • even the merge build, that ran before, now fails when run manually, yet no code has changed in main

@planetf1 planetf1 assigned planetf1 and unassigned wbittles May 27, 2021
planetf1 added a commit that referenced this issue May 27, 2021
…aviour

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 27, 2021
#16 remove maven local repo reference - causes inconsistent build beh…
planetf1 added a commit that referenced this issue May 27, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 27, 2021
planetf1 added a commit that referenced this issue May 27, 2021
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
planetf1 added a commit that referenced this issue May 27, 2021
@planetf1
Copy link
Member Author

planetf1 commented Jun 7, 2021

This should be done, so closing. WIll validate release pipeline when we are ready to release.

@planetf1 planetf1 closed this as completed Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants