Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

#85 Initial version of Glossary Author explorer #108

Merged
merged 26 commits into from
Mar 16, 2021
Merged

#85 Initial version of Glossary Author explorer #108

merged 26 commits into from
Mar 16, 2021

Conversation

davidradl
Copy link
Member

No description provided.

@davidradl
#41 handle incorrect server in url
118b3f7 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Merge branch 'main' of https://github.com/odpi/egeria-react-ui into main
8db7aab
@davidradl
#89 fix merge issues
d339f52 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 initial commit of glossary author visualisation
12cb908 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 putting something on the canvas with errors
fd453b8 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 putting 1 node on the canvas with errors
a46d481 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 remove duplicate graph button
db06699 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 remove duplicate graph button
afdde5e 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 populate properties of initial node
a823821 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 correct node type value
9e61577 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 show 1 level of traversal
2fd96d1 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 add labels to links in diagram
b4d9a8b 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#87 Add commented out code around icons. Activate later
0fda4ec 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#95 correct clear and undo in glossary author visualisation
ccdd89e 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#4829 Fix undo processing
8ec0e3f 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#95 change clear to refresh the page
cfa352d 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#95 display line
ad54b28 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#95 add icons
27bacda 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 correct category hierarchy
123c8ab 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Merge branch 'main' of https://github.com/odpi/egeria-react-ui into g…
353397e 
…it85
@davidradl
#85 remove references to rex or repository from Glove
1f74b1b 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 remove commented out code
1b0f0b6 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl davidradl requested review from planetf1 and sarbull March 16, 2021 14:21
sarbull
sarbull reviewed Mar 16, 2021
View reviewed changes
docs/design/glossary-author/README.md Outdated




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we need more of this kind of documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I mistakenly added a confused icon. Sorry for the confusion @sarbull

@davidradl
#85 underline selected label
d0ef860 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 remove unnecessary code
87eec21 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 fix readme typos
1cd2eea 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
#85 remove readme blank lines
463135d 
Signed-off-by: David Radley <david_radley@uk.ibm.com>
@davidradl
Copy link
Member Author

@planetf1 @sarbull I will merge at the end of tomorrow if I hear no more feedback.

planetf1
planetf1 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular feedback from me - not had a chance and not JS developer. Since it's a new function I think it's fine to merge & then critique/review ?

@davidradl
Copy link
Member Author

@planetf1 @sarbull OK I will merge.

@davidradl davidradl merged commit 6556531 into odpi:main Mar 16, 2021
@davidradl davidradl deleted the git85 branch March 16, 2021 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarbull sarbull sarbull left review comments

@planetf1 planetf1 planetf1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidradl @sarbull @planetf1