Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

git380 add ability to disable certificate validation #391

Merged
merged 2 commits into from
Apr 13, 2022
Merged

git380 add ability to disable certificate validation #391

merged 2 commits into from
Apr 13, 2022

Conversation

davidradl
Copy link
Member

Signed-off-by: David Radley dgradley@gmail.com

@davidradl
git3888 add ability to disable certificate validation
c4ddebb 
Signed-off-by: David Radley <dgradley@gmail.com>
@davidradl davidradl requested a review from planetf1 March 31, 2022 19:21
planetf1
planetf1 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested running the UI locally, against a cloud-deployed coco pharma lab helm chart on k8s
Works fine with the override set.

Once merged I'll do a chart update to set this variable, and bring the UI up to date - initially as a dev version

@planetf1 planetf1 marked this pull request as ready for review April 13, 2022 11:35
@planetf1
Copy link
Member

Moving out of draft & updating - agreed ok to merge.

@planetf1 planetf1 enabled auto-merge April 13, 2022 11:36
@planetf1 planetf1 mentioned this pull request Apr 13, 2022
Closed
@planetf1 planetf1 merged commit 30bcdb4 into odpi:main Apr 13, 2022
@davidradl davidradl deleted the git380 branch March 30, 2023 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@planetf1 planetf1 planetf1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidradl @planetf1