-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics modeling client - no code, packaging warning #3606
Comments
@yevgenmar is there a plan to add a client? |
Hi Nigel,
I did not have plan for client. As part of documentation I would like to have postman collection as example how to use the OMAS.
Sincerely Yevgeniy
…________________________________
From: Nigel Jones <notifications@github.com>
Sent: September 18, 2020 6:14 AM
To: odpi/egeria <egeria@noreply.github.com>
Cc: yevgenmar <yevgenmar@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [odpi/egeria] Analytics modeling client - no code, packaging warning (#3606)
@yevgenmar<https://github.com/yevgenmar> is there a plan to add a client?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#3606 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABFPQCWURMPWSD4L2YYPKA3SGMXJBANCNFSM4RLHUBZQ>.
|
The postman collection would be useful... I think if we have a general purpose interface we should really have a client, as this is consistent with our other OMASs. Whilst in development it's inevitable the implementation is incomplete, but as we get it closer to released status I think then we should look at it However if there is consensus we don't need/want a client then we can remove the stub build files to avoid the initial error above. A long time ago we put together some guidelines for OMASs though having read them they are only rough notes, and as a community we need to improve! (fyi https://github.com/odpi/egeria/blob/master/developer-resources/standards-for-omas-implementations.md ) |
FYI error from publishing build 2.4:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
If there is no need, and no intent, to provide a client, I suggest that module is removed. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions. |
If it's intended to implement this I suggest leaving it open, otherwise please feel free to close @yevgenmar |
When publishing the 2.2 release in #3518 we get a warning:
This is because the pom for this module says it is a jar, yet there is no code present.
Is the intent to add client code? If so let's leave as is.
In general with a module if there isn't code it should be removed -- however this would be inconsistent with other OMASs
The text was updated successfully, but these errors were encountered: