Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics modeling client - no code, packaging warning #3606

Closed
planetf1 opened this issue Sep 14, 2020 · 10 comments
Closed

Analytics modeling client - no code, packaging warning #3606

planetf1 opened this issue Sep 14, 2020 · 10 comments
Assignees
Labels
enhancement New feature or request no-issue-activity Issues automatically marked as stale because they have not had recent activity.

Comments

@planetf1
Copy link
Member

When publishing the 2.2 release in #3518 we get a warning:

2020-09-13T09:49:36.2977485Z RESULT - Sync analytics-modeling-client:2.2 = {"message":"In order to sync to Maven Central your package must be included in the JCenter repository"}

This is because the pom for this module says it is a jar, yet there is no code present.

Is the intent to add client code? If so let's leave as is.
In general with a module if there isn't code it should be removed -- however this would be inconsistent with other OMASs

@planetf1
Copy link
Member Author

^ @yevgenmar

@planetf1 planetf1 mentioned this issue Sep 14, 2020
17 tasks
@planetf1 planetf1 assigned planetf1 and unassigned planetf1 Sep 16, 2020
@planetf1
Copy link
Member Author

@yevgenmar is there a plan to add a client?

@yevgenmar
Copy link
Contributor

yevgenmar commented Sep 18, 2020 via email

@planetf1 planetf1 added the enhancement New feature or request label Sep 18, 2020
@planetf1
Copy link
Member Author

The postman collection would be useful... I think if we have a general purpose interface we should really have a client, as this is consistent with our other OMASs.

Whilst in development it's inevitable the implementation is incomplete, but as we get it closer to released status I think then we should look at it

However if there is consensus we don't need/want a client then we can remove the stub build files to avoid the initial error above.

A long time ago we put together some guidelines for OMASs though having read them they are only rough notes, and as a community we need to improve! (fyi https://github.com/odpi/egeria/blob/master/developer-resources/standards-for-omas-implementations.md )

@planetf1
Copy link
Member Author

planetf1 commented Nov 4, 2020

FYI error from publishing build 2.4:

Hi planetf1,

Thank you for submitting this request,

JCenter follows the maven convention. In addition to the .jar and .pom file, your version should include a sources jar, and optionally a javadoc jar.

Your files should be under a maven path layout.
(See https://www.jfrog.com/confluence/display/BT/Central+Repositories+New+UI#CentralRepositoriesNewUI-JCenter)

@planetf1 planetf1 mentioned this issue Nov 4, 2020
20 tasks
@planetf1 planetf1 mentioned this issue Dec 14, 2020
22 tasks
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jan 4, 2021
@planetf1 planetf1 removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jan 4, 2021
@planetf1
Copy link
Member Author

planetf1 commented Feb 4, 2021

If there is no need, and no intent, to provide a client, I suggest that module is removed.

@planetf1 planetf1 assigned yevgenmar and unassigned planetf1 Feb 4, 2021
@planetf1 planetf1 mentioned this issue Feb 8, 2021
23 tasks
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Apr 6, 2021
@planetf1 planetf1 removed the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Apr 8, 2021
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 20 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the no-issue-activity Issues automatically marked as stale because they have not had recent activity. label Jun 8, 2021
@planetf1
Copy link
Member Author

planetf1 commented Jun 8, 2021

If it's intended to implement this I suggest leaving it open, otherwise please feel free to close @yevgenmar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity Issues automatically marked as stale because they have not had recent activity.
Projects
None yet
Development

No branches or pull requests

2 participants