#7254 increase poll retry count for cts #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nigel Jones nigel.l.jones+git@gmail.com
Description
Related Issue(s)
See #7254
Testing
will test effect of change in github actions
Release Notes & Documentation
Additional notes
Timeout was initially increased as part of 7e4a909 in #6452
In #6435 we hit exactly the same issues as #7254, and doubling the timeout addressed the issue, at least for a well-specced k8s environment. This fix does a further doubling to cater for more constrained systems, including github actions.
It's hoped this is sufficient.
Selected cts tests have to wait for an event to be received so are intrinsically dependent on system performance. We should have sufficiently high timeouts that this is really only a protection against complete failure.