SafeRegEx check should allow invlid RegExs #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...metadata/adapters/repositoryservices/postgres/repositoryconnector/database/QueryBuilder.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a change to the SafeRegEx test which is looking for valid RegEx's that are designed to cause a denial of service by taking a very long time. The routine is passed any string that might be a regex - and this includes strings that are complex names of techinical metadata elements which include special characters from a RegEx point of view - but are not valid RegEx expressions. These are not a concern, because they are probably being passed as an exact value comparison - and if it turns out they are being passed as a RegEx then the database will fail it immediately. So exceptions from invalid RegEx expressions are now ignored rather than putting out alarming exception messages on the console.
Related Issue(s)
None
Testing
Restarting the server with the fix multiple times.
Release Notes & Documentation
None
Additional notes
None