feat(results): Basic results implementation #158
Conversation
There was a problem hiding this comment.
@caviri I accidentally started to review this PR as well, but then noticed that you haven't requested a review yet, since I think this PR iw not ready for review yet, correct? Anyway maybe my comment will be helpful to you in moving forward.
| ), | ||
| ): | ||
| try: | ||
| if dt_name is None and dt_id is None: |
There was a problem hiding this comment.
suggestion: I think overall the PR iff fine for me. but I would suggest to put the logic into the db function rather then in the cli command. There you can raise an exception if something goes wrong such as if the S3 connection can not be established. This way you will also better know what happened, whereas if you have the logic in the cli the command will just stop at a certain point in the try except block.
I think it is just best practice to not have the logic in the cli command but rather in function that you call from the cli. That way the logic can also be reused later by the dashboard for example.
sabinem
changed the title
sabinem
changed the title
This is the initial implementation for results.
One digital twin can have one first result associated. This will be generated automatically after the digital twin generation.