Authentication branch: Fix docker config #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ARG ODTP_PATH and PIP_INSTALL_ARGS
Remove the volume: ${APP_PATH}:/app
sabinem
requested changes
Jun 28, 2024
There was a problem hiding this comment.
@sabrinaossey We are already using ODTP_PATH in the code with another meaning. Therefore please use APP_PATH for mounting the app directory. Please make the suggested changes an see whether this works for you as well.
| @@ -1,6 +1,8 @@ | |||
| # Use Docker in Docker stable version | |||
| ARG ODTP_PATH | |||
There was a problem hiding this comment.
Please rename this into APP_PATH since we already have ODTP_PATH used internally in the code with an other meaning.
| @@ -14,7 +15,6 @@ services: | |||
| volumes: | |||
| - /var/run/docker.sock:/var/run/docker.sock | |||
| - ${ODTP_PATH}:${ODTP_PATH} | |||
| - ${APP_PATH}:/app | |||
There was a problem hiding this comment.
We need APP_PATH still mounted.
| @@ -6,6 +6,7 @@ services: | |||
| context: . | |||
| args: | |||
| PIP_INSTALL_ARGS: ${PIP_INSTALL_ARGS} | |||
| ODTP_PATH: ${ODTP_PATH} | |||
There was a problem hiding this comment.
maybe this her should then be APP_PATH as well.
sabinem
changed the title
sabinem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.