Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH Workflow for cross-platform tests #648

Merged
merged 19 commits into from
May 18, 2020
Merged

Add GH Workflow for cross-platform tests #648

merged 19 commits into from
May 18, 2020

Conversation

ibnesayeed
Copy link
Member

This utilizes matrix of OSes, Python and IPFS versions to perform tests of various combinations.

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   27.28%   27.28%           
=======================================
  Files           7        7           
  Lines        1246     1246           
  Branches      191      191           
=======================================
  Hits          340      340           
  Misses        881      881           
  Partials       25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c76fa...ec0d17a. Read the comment docs.

@ibnesayeed
Copy link
Member Author

It looks like Windows tests are halting. We need to test it manually on a Windows machine as following:

  • Install Windows Server 2019
  • Ensure Bash and cURL are installed in it
  • Install NodeJS 12
  • Install Python 3.7 or 3.8
  • Install IPFS (i.e., download and extract the binary and set PATH accordingly)
  • Run IPFS daemon
  • Run ipfs cat on the welcome file
  • Clone IPWB
  • Run IPWB tests

@ibnesayeed
Copy link
Member Author

This aims to resolve #630, but Windows environment is not behaving well. I think we can move with what we have working here and revisit Windows later.

@ibnesayeed
Copy link
Member Author

@machawk1: 3.8 is problematic on some systems

That's why we are testing 3.7 and 3.8 both on various platforms using matrix, but inside a Docker container we can more confidently go for the latest Python.

@ibnesayeed
Copy link
Member Author

@machawk1 should we abstract out the task of linting the code as a separate job and not repeat it in every matrix environment?

@machawk1
Copy link
Member

@ibnesayeed Yes, only need to lint in one environment. No need to repeat.

@ibnesayeed
Copy link
Member Author

@machawk1 this is in good shape (other than Windows, which is commented out for now).

@machawk1
Copy link
Member

@ibnesayeed I should have some time to explore and evaluate this tomorrow (May 14) afternoon.

@ibnesayeed
Copy link
Member Author

It looks like the codecov utility is a not an independent tool, but a way to submit results to codecov.io for reporting, hence removing it from the workflow.

@ibnesayeed
Copy link
Member Author

Windows tests are still failing and taking forever to complete, likely due to IPWB bugs (because the action otherwise runs tests on all platforms fine).

Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machawk1 machawk1 merged commit 43936d2 into master May 18, 2020
@ibnesayeed ibnesayeed deleted the issue-630 branch May 18, 2020 20:38
@github-actions github-actions bot mentioned this pull request Jun 8, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants