-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Workflow for cross-platform tests #648
Conversation
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 27.28% 27.28%
=======================================
Files 7 7
Lines 1246 1246
Branches 191 191
=======================================
Hits 340 340
Misses 881 881
Partials 25 25 Continue to review full report at Codecov.
|
It looks like Windows tests are halting. We need to test it manually on a Windows machine as following:
|
This aims to resolve #630, but Windows environment is not behaving well. I think we can move with what we have working here and revisit Windows later. |
That's why we are testing 3.7 and 3.8 both on various platforms using matrix, but inside a Docker container we can more confidently go for the latest Python. |
@machawk1 should we abstract out the task of linting the code as a separate job and not repeat it in every matrix environment? |
@ibnesayeed Yes, only need to lint in one environment. No need to repeat. |
@machawk1 this is in good shape (other than Windows, which is commented out for now). |
@ibnesayeed I should have some time to explore and evaluate this tomorrow (May 14) afternoon. |
It looks like the |
Windows tests are still failing and taking forever to complete, likely due to IPWB bugs (because the action otherwise runs tests on all platforms fine). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This utilizes matrix of OSes, Python and IPFS versions to perform tests of various combinations.