Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Time Checking of Log Messages #13

Closed
jwillikers opened this issue Apr 14, 2020 · 5 comments
Closed

Compile Time Checking of Log Messages #13

jwillikers opened this issue Apr 14, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@jwillikers
Copy link

The {fmt} library provides the FMT_STRING macro to validate formatting constructs at compile-time. Is it possible to check the log message format at compile-time in Quill?

@odygrd
Copy link
Owner

odygrd commented Apr 16, 2020

Hello,

We already check for it in compile time here

Let me know if you had any issue with this, otherwise this can be closed

@odygrd odygrd added the question Further information is requested label Apr 16, 2020
@jwillikers
Copy link
Author

Thanks for pointing that out!

@odygrd
Copy link
Owner

odygrd commented Apr 17, 2020

Thanks for this. Actually there was a bug and they were not being evaluated. It should now be fixed : )

@odygrd odygrd added bug Something isn't working and removed question Further information is requested labels Apr 17, 2020
@jwillikers
Copy link
Author

Glad to know I have at least some shred of sanity left 😂
I figured I'd look into it more when I had time... but I probably should have left more information about the crash I was experiencing at runtime when attempting to format a boost::filesystem::path, huh? :)

@odygrd
Copy link
Owner

odygrd commented Apr 17, 2020

Thanks for reporting. You can try again with the fix and if you have more issues let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants