Support 'Windows Server 2016, Windows 10 LTSB 2016 and Windows 10 version 1607' #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows Server 2016, Windows 10 LTSB 2016 and Windows 10 version 1607: GetThreadDescription and SetThreadDescription are only available by Run Time Dynamic Linking in KernelBase.dll. see: https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreaddescription
|
thanks a lot for the PR and for fixing this : ) |
|
Thanks for merging, but I'm afraid I've added a new bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quill cannot be used in any of the windows versions in the title as it uses GetThreadDescription and SetThreadDescription directly.
The limitiation is also mentioned at https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreaddescription:
Windows Server 2016, Windows 10 LTSB 2016 and Windows 10 version 1607: GetThreadDescription is only available by [Run Time Dynamic Linking](https://learn.microsoft.com/en-us/windows/win32/dlls/using-run-time-dynamic-linking) in KernelBase.dll.This merge request fixes that as Set/GetThreadDescription can be used with LoadLibrary.
Github doesn't allow me to upload a screenshot to this issue, but if you run an exe on Windows Server 2016 which is build with quill it will say
"The procedure entry point SetThreadDescription could not be located in the dynamic library" on startup.