added accessor method for Logger name #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty minor but it would be useful for me. My use case is that I've implemented log level inheritance as a function of logger names, like log4cxx and (I think) log4j have. E.g., if you set the log level for logger "foo", then all loggers named "foo.xyz" for any xyz will automatically use the same log level as logger "foo".
If I had to, I could keep track of the logger names myself, via e.g. map<quill::Logger*, std::string> but since the Logger already has its name this seemed reasonable and obviously much more ergonomic for my case.
I considered adding accessors for some of the other things in LoggerDetails, but decided against it since I don't currently have any need for them.