This repository has been archived by the owner on Jan 27, 2019. It is now read-only.
Two leftover oven patches #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esben
reviewed
Nov 10, 2016
| @@ -274,6 +277,7 @@ def wait(self, poll=False): | |||
| if self.result is not None: | |||
| # Something bad happened in start | |||
| self.cleanup_context() | |||
| self.func_end = oelite.util.now() | |||
There was a problem hiding this comment.
What is the point of recording self.func_end here? It only seems to be used later on in the function, which will never be reached in this case.
There was a problem hiding this comment.
Good catch, probably a refactoring artifact. Moreover, there's no reason to store func_end in self, we can just use a local variable (like prefunc_start). Will push a fixed version.
added 2 commits
November 10, 2016 14:29
All pre- and post-funcs run synchronously in the main oe process. Some of these tend to be rather time-consuming, so it would be better if they could be made into tasks of their own, or run as part of the main task function, or just optimized to run faster. Otherwise, the oven risks being underused for a long time (for example, some do_install script finishes, and we go on to execute the associated postfuncs, which may take > 30 seconds to complete - meanwhile, some do_compile task has finished, but there's no way we'll notice before we're done with those postfuncs). Knowing which tasks' pre- and postfuncs take a long time is useful for finding recipes (or maybe whole classes) that are worth optimizing.
There's just a tad too many digits in "native:bzip2_1.0.6:do_package finished - 1.51460909843 s". Print all time deltas with "%.3f".
Villemoes
force-pushed
the
ravi/oventweaks
branch
from
43a3af6 to
f538036
Compare
esben
approved these changes
Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left these out of the big parallel PR mostly because I had to draw a line somewhere.