Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding transparent colours on nft format #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Marco4413
Copy link

Adding what was mentioned on issue #69

@oeed
Copy link
Owner

oeed commented May 25, 2020

Hmmm the main issue I have really is that NFT is something that's already pretty widely used and wasn't even created by any of us; so nothing would really change.

Worth noting though that (if memory serves correct) you can just use a space character for transparent foreground.

@Marco4413
Copy link
Author

You're right but having transparent background and using a space character would mean "don't modify that pixel" and that's what I need. Now I've got a question, what if the color specified isn't a valid hex... Should the color be set to transparent, should the program error or should it use the last color that was set to text/background?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants