feat!(twitter): update twitter spec #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4af0b46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryoppippi
force-pushed
the
feature/v4-twitter
branch
from
16ea6c8
to
4e5952b
Compare
|
Looks good, but the newly added properties aren't there, so I'd like you to add tests. There are a lot of properties, so add a new |
ryoppippi
force-pushed
the
feature/v4-twitter
branch
3 times, most recently
from
998be32
to
aeb5db8
Compare
ryoppippi
force-pushed
the
feature/v4-twitter
branch
from
aeb5db8
to
6cb8367
Compare
ryoppippi
force-pushed
the
feature/v4-twitter
branch
from
8715987
to
fd86218
Compare
|
@oekazuma done! |
ryoppippi
force-pushed
the
feature/v4-twitter
branch
from
3132e7e
to
747e05e
Compare
|
I missed some elements in test, so I added |
ryoppippi
force-pushed
the
feature/v4-twitter
branch
from
8c16e6b
to
4af0b46
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I added a twitter update.
I create this PR as a draft.
If this is okay, |'ll generate a changeset