Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for experimental node access API #46

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

p-snft
Copy link
Member

@p-snft p-snft commented Jan 11, 2024

As #45 might take some time to be implemented, I am marking the current API as a draft.

@pep8speaks
Copy link

pep8speaks commented Jan 11, 2024

Hello @p-snft! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-11 19:33:49 UTC

p-snft and others added 3 commits January 11, 2024 17:48
Double use of the name es also caused an error being hard to detect.
@p-snft p-snft merged commit 21d727f into dev Jan 11, 2024
12 checks passed
@p-snft p-snft deleted the feature/node_dict_warning branch January 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants