Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate dump/restore in basic example #1040

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Conversation

p-snft
Copy link
Member

@p-snft p-snft commented Jan 23, 2024

This is not really "basic" and can lead to errors. I still left it in and put some additional explanation so that beginners learn about the concept but do not have it in their code without thinking about it.

This is not really "basic" and can lead to errors. I still left it in
and put some additional explanation so that beginners learn about the
concept but do not have it in their code without thinking about it.
@p-snft p-snft self-assigned this Jan 23, 2024
@p-snft p-snft requested review from a team January 23, 2024 10:16
examples/basic_example/basic_example.py Fixed Show resolved Hide resolved
examples/basic_example/basic_example.py Fixed Show fixed Hide fixed
MedinavonLevetzow and others added 2 commits March 5, 2024 21:28
Although it is just an example, having hard-coded unreachable
code can be considered bad style.
@pep8speaks
Copy link

pep8speaks commented Mar 7, 2024

Hello @p-snft! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-07 09:56:53 UTC

p-snft and others added 5 commits March 7, 2024 10:56
Co-authored-by: Patrik Schönfeldt <github@patrikschoenfeldt.de>
Co-authored-by: Patrik Schönfeldt <github@patrikschoenfeldt.de>
Improved variable naming and formatting in 'basic_example.py' for enh…
@@ -71,28 +71,54 @@
from oemof.solph import EnergySystem
from oemof.solph import Model
from oemof.solph import buses
from oemof.solph import components as cmp
from oemof.solph import components

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'components' is not used.
@p-snft p-snft merged commit 0986292 into dev Apr 2, 2024
11 of 14 checks passed
@p-snft p-snft deleted the revision/basic_example branch April 2, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants