Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage and investment storage block docstrings #735

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

simnh
Copy link
Member

@simnh simnh commented Dec 14, 2020

This PR fixes (hopefully) minor errors in the doc of the GenericStorageBlock and GenericStorageInvementBlock docstring.

@simnh simnh requested a review from p-snft December 14, 2020 08:59
@simnh simnh self-assigned this Dec 14, 2020
(InvestmentFlow.invest(n, target(n)) + existing) * \\
invest\_relation\_input\_output(n) \\
\forall n \in \textrm{INVEST\_REL\_IN\_OUT}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not remove it from the docs, because this constraint exists. There should be more information added. Something like "In case invest_relation_input_output is set (or not None)`, the following constraint is build:"

@joroeder
Copy link
Member

PR relates to issue #734

@uvchik uvchik marked this pull request as draft May 20, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants