Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove facade relicts #135

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Remove facade relicts #135

merged 6 commits into from
Oct 11, 2023

Conversation

nailend
Copy link
Collaborator

@nailend nailend commented Oct 5, 2023 •
edited
Loading

Description

After conversion of the facades in separate files, the old classes in the facade.py have not been removed.
This were now removed.

Further pre-commit hooks were adapted to only take tracked files into account.

Type of change

Please tick or delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added new features/fixes to the CHANGELOG

nailend added 3 commits October 5, 2023 19:00
@nailend
Remove specific dirs from flake8
fd7f750
@nailend
Remove specific dirs from isort
b964923
@nailend
Remove old facade classes from facade.py
5c5f766 
The classes have already been moved to separate files in
the facade directory. So this are just dulicates.
@nailend nailend requested a review from henhuy October 5, 2023 17:07
@nailend nailend self-assigned this Oct 5, 2023
henhuy
henhuy requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move pre-commit changes into separate PR and issue.
Otherwise I totally approve removing facades!

@nailend nailend changed the title Remove old facade relictes Remove old facade relicts Oct 11, 2023
@nailend nailend changed the title Remove old facade relicts Remove facade relicts Oct 11, 2023
@nailend nailend merged commit 6cad31b into dev Oct 11, 2023
0 of 3 checks passed
@nailend nailend linked an issue Oct 19, 2023 that may be closed by this pull request
Remove relicts and duplicates #137
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henhuy henhuy henhuy requested changes

Assignees

@nailend nailend

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove relicts and duplicates
2 participants
@nailend @henhuy