Add tests for module compression_heatpumps_and_chillers #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnnr
requested changes
Jan 22, 2020
|
Thanks for the tests! Looks good, just some minor remarks. |
added 3 commits
January 23, 2020 16:16
- improve readability of exceptions
- Remove argument 'consider_icing' in calc_cop - New: argument 'factor_icing' alone triggers icing to be considered
|
Good feedback! |
jnnr
reviewed
Jan 27, 2020
| # Combining 'consider_icing' and mode 'chiller' is not possible! | ||
| cops = None | ||
|
|
||
| raise ValueError('Argument factor ising has ' |
There was a problem hiding this comment.
Suggested change
| raise ValueError('Argument factor ising has ' | |
| raise ValueError("Argument factor_icing has " |
jnnr
reviewed
Jan 27, 2020
| cops = None | ||
|
|
||
| raise ValueError('Argument factor ising has ' | ||
| 'to be None for mode=chiller!') |
There was a problem hiding this comment.
Suggested change
| 'to be None for mode=chiller!') | |
| "to be None for mode='chiller'!") |
jnnr
reviewed
Jan 27, 2020
| @@ -139,6 +158,9 @@ def calc_max_Q_dot_chill(nominal_conditions, cops): | |||
|
|
|||
|
|
|||
| """ | |||
| if not isinstance(cops, list): | |||
| raise TypeError('Argument cops is not of type list!') | |||
There was a problem hiding this comment.
Suggested change
| raise TypeError('Argument cops is not of type list!') | |
| raise TypeError("Argument 'cops' is not of type list!") |
|
Thanks, looks good. Just a little suggestion in for the error messages. Apart from that, it could be merged. In another PR, you could implement the functionality of giving back a pd.Series as result when passing one as input. But that can be dealt with separately. |
jnnr
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compression_heatpumps_and_chillers.py.It also includes two additional changes (I know, I should have done this in seperate PRs - sry!)
2) The PR fixes the docstring of a pre-calculation-function. Before it said the input argument had to be of type list but in fact it can be a pandas.Series as well. I added that information to the docstring.