-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added get_cop to heat_pump.py #7
Open
Pyosch
wants to merge
6
commits into
oemof:dev
Choose a base branch
from
Pyosch:add_cop
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3dc5428
added get_cop to heat_pump.py
Pyosch 63d2a66
moved heat_pump.py to new directory src
Pyosch 56f8b89
changed temperature input from heatbuilding to temperature series
Pyosch bf34914
added warnings and example
Pyosch d991303
adjusted import in heat pump example
Pyosch 41aad29
adjusted import in heat pump example 2
Pyosch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# -*- coding: utf-8 -*- | ||
import pandas as pd | ||
|
||
def get_cop(heatbuilding, heatpump_type = "Air", water_temp = 60): | ||
""" Calculation of the coefficient of performance depending | ||
on the outside temperature | ||
|
||
Parameters | ||
---------- | ||
heatbuilding: object | ||
HeatBuilding object from demandlib.bdew countaining the index | ||
and outside temperature | ||
heatpump_type: string | ||
defines the technology used. Ground is more efficient than Air. | ||
water_temp: int | ||
temperature needed for the heating system | ||
|
||
References | ||
---------- | ||
.. [1]: 'https://www.researchgate.net/publication/255759857_A_review_of_domestic_heat_pumps' | ||
Research paper about domestic heatpumps, containing the formulas used | ||
""" | ||
|
||
cop_lst = [] | ||
|
||
if heatpump_type == "Air": | ||
for tmp in heatbuilding.temperature: | ||
cop = (6.81 - 0.121 * (water_temp - tmp) | ||
+ 0.00063 * (water_temp - tmp)**2) | ||
cop_lst.append(cop) | ||
|
||
elif heatpump_type == "Ground": | ||
for tmp in heatbuilding.temperature: | ||
cop = (8.77 - 0.15 * (water_temp - tmp) | ||
+ 0.000734 * (water_temp - tmp)**2) | ||
cop_lst.append(cop) | ||
|
||
else: | ||
# TODO Raise Error | ||
print("Heatpump type is not defined") | ||
return None | ||
|
||
heatbuilding.cop = pd.DataFrame({"cop" : cop_lst}) | ||
heatbuilding.cop.set_index(heatbuilding.df.index, inplace = True) | ||
|
||
|
||
return heatbuilding.cop |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add:
Returns