Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code update for the Deprecation of 2 constants #296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cooper645
Copy link

  • TEMP_CELSIUS was used from candy, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead

    • Replaced both instances within the code
  • TIME_MINUTES was used from candy, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTime.MINUTES instead

    • Replaced both instances within the code

Replaced both existences of TEMP_CELSIUS with UnitOfTemperature.CELSIUS
Replaced both instances of TIME_MINUTES with UnitOfTime.MINUTES
@cooper645
Copy link
Author

cooper645 commented Aug 8, 2024

I am no coder but it seemed like a simple switch out for a couple of lines of code is all that's required.

Copy link

@matte-oss matte-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this getting merged

cc: @ofalvai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants