Skip to content

Commit

Permalink
(fix) more silliness, updated wrong variables, etc ...
Browse files Browse the repository at this point in the history
  • Loading branch information
MementoRC committed Jun 30, 2024
1 parent 06c889d commit 3d0c1e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion cm_library_c_binding/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,4 @@ add_custom_command(
)

add_custom_target(cffi-c-binding ALL DEPENDS ${CFFI_C_CODE_DIR}/${CFFI_C_CODE})
target_include_directories(cffi-c-binding PUBLIC ${VENDORED_HEADERS_DIR})
add_dependencies(cffi-c-binding headers-for-cffi)
4 changes: 2 additions & 2 deletions cm_python_module/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ if (PROJECT_IGNORE_SYSTEM_LIB OR NOT VENDORED_AS_SYSTEM_LIB_FOUND)
# https://docs.python.org/3/c-api/stable.html#limited-c-api
target_link_libraries(${CFFI_OUTPUT_LIBRARY} PRIVATE ${CFFI_INPUT_LIBRARY})
elseif(VENDORED_AS_SYSTEM_LIB_FOUND)
message(STATUS "Vendored system library found: ${VENDORED_AS_SYSTEM_LIB_LINK_LIBRARIES}")
target_include_directories(${CFFI_OUTPUT_LIBRARY} PRIVATE ${VENDORED_AS_SYSTEM_LIB_LIBRARIES})
message(STATUS "Vendored system library found: ${VENDORED_AS_SYSTEM_LIB_LIBRARIES}")
target_include_directories(${CFFI_OUTPUT_LIBRARY} PRIVATE ${VENDORED_AS_SYSTEM_LIB_INCLUDE_DIRS})
add_dependencies(${CFFI_OUTPUT_LIBRARY} cffi-c-binding)
# On windows, using the LDFLAGS field creates /libpath... secp256k1.lib (correct), but at a later stage
# /libpath is converted to \libpath and fails to be interpreted as a flag by the linker
Expand Down

0 comments on commit 3d0c1e3

Please sign in to comment.