(feat) wrapper to subprocess calls?

[MementoRC]

A lot of times I forgot to put the noqa, thus I had created this wrapper. It also helped me browse through the logs and debug specific calls.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (12bd2e8) to head (b5823a2).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          11       11           
  Lines         566      566           
  Branches       67       67           
=======================================
  Hits          485      485           
  Misses         45       45           
  Partials       36       36           

[MementoRC]

There may be smarter ways to do this, it just makes the debugging a tidbit easier

[ofek]

I see commented out code blocks; is this ready for review?

[MementoRC]

Yes, it is ready, though it is just a small improvement. Right, these are 2 functions that do not seem to be used. I wasn't thinking straight, you would still see them in the review if I had removed them

I updated the PR

On the other front, I am struggling with testing the build with system lib. It builds, but when testing the secp256k1 DLL does not load (it loads fine during build - I changed the libsecp256k1 several times to help debug) - I can't figure out what is missing. Testing involves a virtualenv, then I have to use conda to be able to install the libsecp256k1, then it fails when I try to run the tests - It is so close to be ready

[MementoRC]

@ofek Ready for review - I'll refrain from updating it