Snapshot & VolumeContentSource Support #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just updated the CI secret (added rights to the provisioner service account) |
maennchen
force-pushed
the
snapshot_support
branch
from
c977974 to
d0c4ab0
Compare
This was referenced May 27, 2020
|
@ofek Snapshots were promoted to Beta in K8S If you agree, I would create a new kustomize overlay that adds the relevant stuff for snapshots, but only for When snapshots are completely stable and most people have updated their clusters, I would move the feature from the overlay into the main definition. |
|
That sounds fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12 & #13
TODO
CreateSnapshot&DeleteSnapshot