Fix some ResourceWarnings.

[JulienPalard]

references: #123

So the issue with #123 is funny, I just forgot to bump google-cloud-bigquery minimum version in setup.cfg.

Without bumping it to the release they introduced the context manager, it could have gone mostly right, there's tens of versions since then.

Sadly back then, they had python_requires=">=3.6" and now they have python_requires=">=3.6, <3.10", so when we install google-cloud-bigquery with Python 3.10 it forces pip to crawl back to this old version not enforcing <3.10, but not having __enter__ neither.

I enforced the right version in setup.cfg but we may not want to merge this as it makes pypinfo uninstallable with 3.10 as there does not exist a google-cloud-bigquery recent enough and compatible with py310 (the irony).

[codecov]

Codecov Report

Merging #125 (c696b63) into master (f17e78c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   96.90%   96.92%   +0.01%     
==========================================
  Files           6        6              
  Lines         388      390       +2     
  Branches       47       48       +1     
==========================================
+ Hits          376      378       +2     
  Misses          4        4              
  Partials        8        8              

Impacted Files	Coverage Δ
pypinfo/core.py	93.93% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17e78c...c696b63. Read the comment docs.

[hugovk]

Thanks for digging into that!

I think we should wait for google-cloud-bigquery to be compatible with 3.10 first, here's their tracking issue:

• Python 3.10 support googleapis/python-bigquery#1006

I realise we also weren't testing on 3.10 yet, it was due to other dependencies not yet supporting 3.10, but they do now. So let's also get #126 merged and included in here.

If you like, you could also split out the with open(...) change to another PR.

[hugovk]

Would you like to rebase/merge from master? #127 added tests to cover this.

And no rush, because I think it'll take a while for google-cloud-bigquery to release for 3.10.

[hugovk]

google-cloud-bigquery 2.30.0 has just been released supporting Python 3.10:

• https://pypi.org/project/google-cloud-bigquery/2.30.0/

Suggested change

	google-cloud-bigquery >= 2.11.0
	google-cloud-bigquery >= 2.30.0

[JulienPalard]

I don't think we need 2.30.0:

• In Python 3.9 we can use >=2.11.0.
• In Python 3.10 pip will choose 2.30.0 as it have no choice.

So >= 2.11.0 looks good to me.

[JulienPalard]

We could run two tests in tox, one with the minimum version, and one with the maximum version of out dependencies, to ensure it works, like I'm trying to do here: https://github.com/JulienPalard/oeis/blob/7d6c314c02983c7a47f901d07d0fffc8b772155a/tox.ini#L36;L39 ? Maybe in another PR.

[hugovk]

Ah good point that 3.10 will pick the right one. I think we'll be fine keeping it simpler and testing just a single version. Thanks!

[JulienPalard]

(closed/reopened to let the CI pick the new version in 3.10 so it passes)

[hugovk]

Thank you again!