Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC uses wrong field type for strings #177

Closed
Tracked by #206
offa opened this issue Mar 8, 2023 · 2 comments
Closed
Tracked by #206

MSVC uses wrong field type for strings #177

offa opened this issue Mar 8, 2023 · 2 comments
Assignees
@offa
Labels
bug
Milestone
v0.8.0

Comments

@offa
Copy link
Owner

offa commented Mar 8, 2023

MSVC seems to use bool variant instead of std::string for const char*.
@offa offa added the bug label Mar 8, 2023
@offa offa added this to the v0.8.0 milestone Mar 8, 2023
@offa
Copy link
Owner Author

offa commented Mar 8, 2023 •
edited
Loading

This is a bug, eventually fixed in C++20 (VS 2019 16.10):

offa added a commit that referenced this issue Mar 10, 2023
@offa
Workaround MSVC bug; converting C strings to bool (#177)
4bd80e2 
On MSVC passing 'const char*' assigns a 'bool' to std::variant instead
of std::string. A non-template overload does prevent this, but will
catch '0' as nullptr.

This can be removed once C++20 is used.
@offa offa self-assigned this Mar 10, 2023
@offa
Copy link
Owner Author

offa commented Mar 10, 2023

Workaround implemented. It's no longer necessary once C++20 is used.

@offa offa closed this as completed Mar 10, 2023
@offa offa added the backport label Oct 31, 2023
@offa offa mentioned this issue Oct 31, 2023
Closed
6 tasks
offa added a commit that referenced this issue Nov 2, 2023
@offa
Workaround MSVC bug; converting C strings to bool (#177)
5dde088 
On MSVC passing 'const char*' assigns a 'bool' to std::variant instead
of std::string. A non-template overload does prevent this, but will
catch '0' as nullptr.

This can be removed once C++20 is used.
@offa offa removed the backport label Nov 3, 2023
@offa offa mentioned this issue Dec 11, 2023
Closed
4 tasks
offa added a commit that referenced this issue Feb 13, 2024
@offa
Remove pre C++20 MSVC workaround (#217, #177)
8efa1e6 
This reverts 5dde088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offa offa

Labels
bug
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
1 participant
@offa