Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimization for sshStorage #313

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Performance optimization for sshStorage #313

merged 2 commits into from
Dec 5, 2023

Conversation

Riscue
Copy link
Contributor

@Riscue Riscue commented Dec 5, 2023

Concurrent Writes enabled

Suggested in pkg/sftp#472 (comment)

Uploads are 50x faster then before.

4 GiB file takes 5 hours before concurrent writes (~200KB/s). Now it takes like 10 mins (~10MB/s) on my ISP

m90
m90 reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very promising, thank you. I left one tiny remark, other than that let's release this.

@Riscue
Copy link
Contributor Author

Riscue commented Dec 5, 2023

This looks very promising, thank you. I left one tiny remark, other than that let's release this.

Done. You're welcome.

@m90 m90 merged commit 58573e6 into offen:main Dec 5, 2023
@m90
Copy link
Member

m90 commented Dec 5, 2023

This is now released in v2.34.0 🎉

@Riscue
Copy link
Contributor Author

Riscue commented Dec 5, 2023

This is now released in v2.34.0 🎉

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m90 m90 m90 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Riscue @m90