Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the dvb.monitor() functionality to use webapi.vvo-online.de #30

Closed
wants to merge 2 commits into from

Conversation

jens-maus
Copy link
Member

updated the dvb.monitor() functionality to use webapi.vvo-online.de instead and thus provide more information like realtime/scheduledtime, state and delaytime as well as information on the departure platform.

This refs kiliankoe/vvo#2

…nstead and thus provide more information like realtime/scheduledtime, state and delaytime as well as information on the departure platform.
@ronhippler
Copy link
Collaborator

Is there a reason why you are working on the master and not on the develop branch?

@jens-maus
Copy link
Member Author

jens-maus commented Feb 16, 2017

Well, because I am used to it and for minor changes I refrain from using a branch.

@jens-maus
Copy link
Member Author

Just to let you guys know how these changes can result in some more detailed graphical view on my home automation screen, see here:

screenshot_126

Looking forward to seeing my changes integrated :)

@kiliankoe
Copy link
Member

Seems like this broke the tests, otherwise looks ok to me.

@ronhippler There's still a few changes waiting in #23, including current activity. Got any ideas how to bring all of this together in a sane way? You probably have much better insight into this library than me at this point 😄

@jens-maus
Copy link
Member Author

jens-maus commented Feb 16, 2017

@kiliankoe Yes, the tests need to be adapted to my new changes. However, I don't have the time yet to adapt the tests. Perhaps you guys can adapt them accordingly.

@ronhippler
Copy link
Collaborator

Maybe i replace all EFA requests with the dvb.webapi, so all requests could be used with eduroam.
so i would use the changes here in the develop branch

@jens-maus
Copy link
Member Author

I can of course helo with that if youbare interested. But please first merge this PR

@ronhippler
Copy link
Collaborator

FYI i merged the changes and published it to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants