Version 5 #39
Merged
Version 5 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are some changes: {
origin: {
stop: 'Helmholtzstraße',
city: 'Dresden',
coords: [51.0255443264448, 13.725468471273134]
},
destination: {
stop: 'Postplatz',
city: 'Dresden',
coords: [51.05055059050917, 13.73357173082639]
},
trips: [{
departure: {
stop: 'Helmholtzstraße',
city: 'Dresden',
platform: {name: 2, type: 'Platform'},
time: '2017-03-17T14:55:00.000Z',
coords: [51.0255443264448, 13.725468471273134]
},
arrival: {
stop: 'Postplatz',
city: 'Dresden',
platform: {name: 1, type: 'Platform'},
time: '2017-03-17T15:20:00.000Z',
coords: [51.05055059050917, 13.73357173082639]
},
duration: 25,
interchanges: 2,
nodes: [{
mode: 'Bus',
line: '85',
direction: ' Löbtau Süd',
diva: {number: 21085, network: 'voe'},
duration: 2,
stops: [{
stop: 'Helmholtzstraße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T14:55:00.000Z',
departure: '2017-03-17T14:55:00.000Z'
},
{
stop: 'Regensburger Straße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T14:56:00.000Z',
departure: '2017-03-17T14:56:00.000Z'
},
{
stop: 'Plauen Nöthnitzer Straße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T14:57:00.000Z',
departure: '2017-03-17T14:57:00.000Z'
}],
departure: {
stop: 'Helmholtzstraße',
city: 'Dresden',
platform: {name: 2, type: 'Platform'},
time: '2017-03-17T14:55:00.000Z',
coords: [51.0255443264448, 13.725468471273134]
},
arrival: {
stop: 'Plauen Nöthnitzer Straße',
city: 'Dresden',
platform: {name: 2, type: 'Platform'},
time: '2017-03-17T14:57:00.000Z',
coords: [51.02707818090382, 13.716544704461048]
},
path: [[51.0255353416574, 13.725468137614868],
...]
},
{
mode: 'Footpath',
line: '',
direction: '',
diva: undefined,
duration: 2,
stops: undefined,
departure: undefined,
arrival: undefined,
path: [[51.02707818090382, 13.716544704461048],
...]
},
{
mode: 'Tram',
line: '3',
direction: ' Wilder Mann',
diva: {number: 11003, network: 'voe'},
duration: 6,
stops: [{
stop: 'Plauen Nöthnitzer Straße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:06:00.000Z',
departure: '2017-03-17T15:06:00.000Z'
},
{
stop: 'Münchner Platz',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:07:00.000Z',
departure: '2017-03-17T15:07:00.000Z'
},
{
stop: 'Nürnberger Platz',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:08:00.000Z',
departure: '2017-03-17T15:08:00.000Z'
},
{
stop: 'Reichenbachstraße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:09:00.000Z',
departure: '2017-03-17T15:09:00.000Z'
},
{
stop: 'Hauptbahnhof',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:11:00.000Z',
departure: '2017-03-17T15:11:00.000Z'
},
{
stop: 'Hauptbahnhof Nord',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:12:00.000Z',
departure: '2017-03-17T15:12:00.000Z'
}],
departure: {
stop: 'Plauen Nöthnitzer Straße',
city: 'Dresden',
platform: {name: 1, type: 'Platform'},
time: '2017-03-17T15:06:00.000Z',
coords: [51.02795994992541, 13.716491750576427]
},
arrival: {
stop: 'Hauptbahnhof Nord',
city: 'Dresden',
platform: {name: 1, type: 'Platform'},
time: '2017-03-17T15:12:00.000Z',
coords: [51.041482983761625, 13.735186760804556]
},
path: [[51.02796914408518, 13.716477834868066],
...]
},
{
mode: 'Tram',
line: '9',
direction: ' Kaditz',
diva: {number: 11009, network: 'voe'},
duration: 5,
stops: [{
stop: 'Hauptbahnhof Nord',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:15:00.000Z',
departure: '2017-03-17T15:15:00.000Z'
},
{
stop: 'Walpurgisstraße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:16:00.000Z',
departure: '2017-03-17T15:16:00.000Z'
},
{
stop: 'Prager Straße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:18:00.000Z',
departure: '2017-03-17T15:18:00.000Z'
},
{
stop: 'Postplatz',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: '2017-03-17T15:20:00.000Z',
departure: '2017-03-17T15:20:00.000Z'
}],
departure: {
stop: 'Hauptbahnhof Nord',
city: 'Dresden',
platform: {name: 1, type: 'Platform'},
time: '2017-03-17T15:15:00.000Z',
coords: [51.041482983761625, 13.735186760804556]
},
arrival: {
stop: 'Postplatz',
city: 'Dresden',
platform: {name: 1, type: 'Platform'},
time: '2017-03-17T15:20:00.000Z',
coords: [51.05055059050917, 13.73357173082639]
},
path: [[51.041492180131286, 13.73517284486511],
...]
}]
},
...
]
};any wishes for improvement? |
…dd modes for footpath, elevator, stairs and escalator
{ origin:
{ stop: 'Helmholtzstraße',
city: 'Dresden',
coords: [ 51.0255443264448, 13.725468471273134 ] },
destination:
{ stop: 'Postplatz',
city: 'Dresden',
coords: [ 51.05055059050917, 13.73357173082639 ] },
trips:
[ { departure:
{ stop: 'Helmholtzstraße',
city: 'Dresden',
platform: { name: '1', type: 'Platform' },
time: 2017-03-18T07:32:00.000Z,
coords: [ 51.0255443264448, 13.725468471273134 ] },
arrival:
{ stop: 'Postplatz',
city: 'Dresden',
platform: { name: '1', type: 'Platform' },
time: 2017-03-18T07:58:00.000Z,
coords: [ 51.05055059050917, 13.73357173082639 ] },
duration: 26,
interchanges: 1,
nodes:
[ { mode:
{ title: 'Bus',
name: 'Bus',
icon_url: 'https://www.dvb.de/assets/img/trans-icon/transport-bus.svg' },
line: '85',
direction: ' Striesen',
diva: { number: 21085, network: 'voe' },
duration: 5,
stops:
[ { stop: 'Helmholtzstraße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: 2017-03-18T07:32:00.000Z,
departure: 2017-03-18T07:32:00.000Z },
{ stop: 'Stadtgutstraße',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: 2017-03-18T07:34:00.000Z,
departure: 2017-03-18T07:34:00.000Z },
{ stop: 'Räcknitzhöhe',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: 2017-03-18T07:35:00.000Z,
departure: 2017-03-18T07:35:00.000Z },
... 1 more item ],
departure:
{ stop: 'Helmholtzstraße',
city: 'Dresden',
platform: { name: '1', type: 'Platform' },
time: 2017-03-18T07:32:00.000Z,
coords: [ 51.0255443264448, 13.725468471273134 ] },
arrival:
{ stop: 'Zellescher Weg',
city: 'Dresden',
platform: { name: '1', type: 'Platform' },
time: 2017-03-18T07:37:00.000Z,
coords: [ 51.02832041479808, 13.746156560504263 ] },
path:
[ [ 51.0255353416574, 13.725468137614868 ],
[ 51.02548641939806, 13.725737159122861 ],
[ 51.025347580931665, 13.726615787933762 ],
... 27 more items ] },
{ mode:
{ title: 'Fussweg',
name: 'Footpath',
icon_url: 'https://m.dvb.de/img/walk.svg' },
line: '',
direction: '',
diva: undefined,
duration: 2,
stops: undefined,
departure: undefined,
arrival: undefined,
path:
[ [ 51.02832041479808, 13.746156560504263 ],
[ 51.02815545483111, 13.745765462052999 ] ] },
{ mode:
{ title: 'Straßenbahn',
name: 'Tram',
icon_url: 'https://www.dvb.de/assets/img/trans-icon/transport-tram.svg' },
line: '11',
direction: ' Bühlau',
diva: { number: 11011, network: 'voe' },
duration: 12,
stops:
[ { stop: 'Zellescher Weg',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: 2017-03-18T07:46:00.000Z,
departure: 2017-03-18T07:46:00.000Z },
{ stop: 'Strehlener Platz',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: 2017-03-18T07:48:00.000Z,
departure: 2017-03-18T07:48:00.000Z },
{ stop: 'Lennéplatz',
city: 'Dresden',
type: 'Stop',
platform: [Object],
coords: [Object],
arrival: 2017-03-18T07:49:00.000Z,
departure: 2017-03-18T07:49:00.000Z },
... 6 more items ],
departure:
{ stop: 'Zellescher Weg',
city: 'Dresden',
platform: { name: '1', type: 'Platform' },
time: 2017-03-18T07:46:00.000Z,
coords: [ 51.02815545483111, 13.745765462052999 ] },
arrival:
{ stop: 'Postplatz',
city: 'Dresden',
platform: { name: '1', type: 'Platform' },
time: 2017-03-18T07:58:00.000Z,
coords: [ 51.05055059050917, 13.73357173082639 ] },
path:
[ [ 51.02815545483111, 13.745765462052999 ],
[ 51.02838777921612, 13.74585972546861 ],
[ 51.02853945426672, 13.745936703348258 ],
... 117 more items ] } ] },
... 3 more items ] } |
|
I'm not sure an actual review here is possible anymore^^ 5/85 tests seem to be failing locally though, mostly regarding ServiceErrors. Going to have a look at that. |
|
I did not update the mocks. Run test-live to run against the api. I would like to get feedback about the new interface and the names. |
|
Ah, you're right. Live tests are working fine. I'm really digging the typescript rewrite! Definitely looks good to me! |
kiliankoe
approved these changes
Oct 17, 2017
ronhippler
force-pushed
the
develop
branch
2 times, most recently
from
3a97b3c to
758384e
Compare
|
its alive 🧟 |
…at], fix pin connections
* master: 4.3.7 fix readme: remove route 4.3.6 remove route, update dependencies Fix for whitespace in front of direction Call coordinate conversion with explicit data type # Conflicts: # .travis.yml # README.md # index.js # lib/monitor.js # lib/utils.js # package.json # test/test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converted to use webapi.vvo-online.de,
handle error